-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51535/
-----------------------------------------------------------

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
-------

I discovered this one during a failed attempt to update to a new mock version. 
I have only aimed for a minimal fix:

* incorrect usage of PropertyMock: 
https://docs.python.org/dev/library/unittest.mock.html#unittest.mock.PropertyMock
  
* assert_called_once() does not exist: 
https://engineeringblog.yelp.com/2015/02/assert_called_once-threat-or-menace.html


Diffs
-----

  src/test/python/apache/aurora/admin/test_admin.py 
fd3b91938b5b67ea59d3955dd94a046b3181be2d 

Diff: https://reviews.apache.org/r/51535/diff/


Testing
-------

Made sure it fails if the production method is tempered with.
./pants test.pytest src/test/python/apache/aurora/admin::


Thanks,

Stephan Erb

Reply via email to