-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Repository: aurora


Description
-------

- Scheduler updater will not use watch_sec if health check is enabled
- Add unit tests for successful updates.

Assumptions on executor change:
The executor starts health check at STARTING, if a successful health check is 
performed before initial_interval_sec expires, the executor will sends a status 
message for RUNNING.

What I try to implement:
vCurrent updater will infer the executor version from the presence of a status 
message sent by the executor during RUNNING status update. 

For vPrev executor:
    The vCurrent updater will use watch_sec for instance update, this is 
independent from the health check.
For vCurrent executor:
    If health check is disabled on vCurrent executor, the vCurrent updater will 
use watch_sec for instance update.
    If health check is enabled on vCurrent executor, the vCurrent updater will 
not use watch_sec for instance update.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 
c129896d8cd54abd2634e2a339c27921042b0162 
  src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java 
c78c7fbd7d600586136863c99ce3d7387895efee 

Diff: https://reviews.apache.org/r/51536/diff/


Testing
-------

./gradlew build

./gradlew :test --tests 
"org.apache.aurora.scheduler.updater.InstanceUpdaterTest"


Thanks,

Kai Huang

Reply via email to