> On Aug. 30, 2016, 10:56 a.m., Zameer Manji wrote: > > LGTM modulo updating the docs about restarting all instances at the same > > time. > > > > Could you also file a ticket to track the removal of the `zk_use_curator` > > flag in 0.17? I did not see one on JIRA. > > John Sirois wrote: > The language of https://issues.apache.org/jira/browse/AURORA-1669 tracks > the flag deprecatation and removal along with the removal of commons code. > If that is too fat a ticket I can break a new one out.
That ticket is fine, thanks for ensuring we don't drop this on the floor. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51506/#review147322 ----------------------------------------------------------- On Aug. 30, 2016, 1:25 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51506/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 1:25 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > ------- > > The flag is noted as deprecated for removal in 0.17.0. > > RELEASE-NOTES.md > | 2 ++ > docs/reference/scheduler-configuration.md > | 4 ++-- > examples/vagrant/upstart/aurora-scheduler.conf > | 1 - > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java > | 11 +++++++++-- > 4 files changed, 13 insertions(+), 5 deletions(-) > > > Diffs > ----- > > RELEASE-NOTES.md f6b609f6f21d6dddfc45d79577b5070736e38ae2 > docs/reference/scheduler-configuration.md > c0c39442725c970e5f9811cd7b4ab3104364c671 > examples/vagrant/upstart/aurora-scheduler.conf > dd60981564286e5b25546737fdd0ce08b0168ed4 > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java > 36ad18c49c5693031136440ab163070f9ffa9405 > > Diff: https://reviews.apache.org/r/51506/diff/ > > > Testing > ------- > > Locally green: > ``` > ./gradlew -Pq build > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
