Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

[Aurora ReviewBot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51564/#review147480
-----------------------------------------------------------



Master (bd11b1c) is red with this patch.
  ./build-support/jenkins/build.sh

                     
.pants.d/python-setup/chroots/ba7cfc27699a9911c627544a2439af78a22bc2df/.deps/mock-1.0.1-py2-none-any.whl/mock.py:1618:
 in _inner
                         return f(*args, **kw)
                     
src/test/python/apache/aurora/executor/common/test_sandbox.py:190: in 
test_uid_exists
                         assert_create_user_and_group(mock_check_call, 
False, True)
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     mock_check_call = <MagicMock name='check_call' 
id='140303160441680'>
                     gid_exists = False, uid_exists = True
                     
                         def assert_create_user_and_group(mock_check_call, 
gid_exists, uid_exists):
                           mock_pwent = pwd.struct_passwd((
                             'someuser',        # login name
                             'hunter2',         # password
                             834,               # uid
                             835,               # gid
                             'Some User',       # user name
                             '/home/someuser',  # home directory
                             '/bin/sh'))        # login shell
                         
                           mock_grent = grp.struct_group((
                             'users',        # group name
                             '*',            # password
                             835,            # gid
                             ['someuser']))  # members
                         
                           exception = subprocess.CalledProcessError(
                     >         
returncode=FileSystemImageSandbox._USER_OR_GROUP_ID_EXISTS,
                               cmd='some command',
                               output=None)
                     E     AttributeError: type object 
'FileSystemImageSandbox' has no attribute '_USER_OR_GROUP_ID_EXISTS'
                     
                     
src/test/python/apache/aurora/executor/common/test_sandbox.py:161: 
AttributeError
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
                      2 failed, 695 passed, 6 skipped, 1 warnings in 
218.37 seconds 
                     
FAILURE


19:43:41 04:06   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 31, 2016, 7:29 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51564/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2016, 7:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Bugs: AURORA-1761
>     https://issues.apache.org/jira/browse/AURORA-1761
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow E_NAME_IN_USE in useradd/groupadd.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> a172691e164cf64792f65f049d698f9758336542 
> 
> Diff: https://reviews.apache.org/r/51564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>