-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147598
-----------------------------------------------------------



Can you set the depends on field of this review to be `51536`? So we know that 
this patch is blocked on that review landing first?

- Zameer Manji


On Sept. 1, 2016, 12:37 p.m., Kai Huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51580/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2016, 12:37 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> A new MTTS (Median Time To Starting) metric is added to the sla module in 
> addition to MTTA and MTTR.
> 
> This review request is related to my previous review request: 
> https://reviews.apache.org/r/51536
> 
> In the new implementation, the executor starts health check at STARTING, if a 
> successful health check is performed before initial_interval_sec expires, it 
> transitions into RUNNING state. Therefore, MTTS gives us an idea of how long 
> it takes for a task to become active, whereas the difference between MTTR and 
> MTTS represents the warm-up period for a task.
> 
> See the following issues for more backgrounds:
> 
> https://issues.apache.org/jira/browse/AURORA-1221
> 
> https://issues.apache.org/jira/browse/AURORA-1222
> 
> The new metrics represents the median time spent waiting for a set of tasks 
> to reach STARTING status within a time frame(including the tasks turning into 
> RUNNING state within the time frame).
> 
> Here I regard STARTING as an active state. However, STARTING state is account 
> for platform and job uptime calculations.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 4f243aab5a2c2f86ec795025e86302a09f864e2d 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> 90ea3a169dadc72e7d7493544ab865ec59d4d425 
> 
> Diff: https://reviews.apache.org/r/51580/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> ./gradlew :test --tests 
> "org.apache.aurora.scheduler.updater.InstanceUpdaterTest"
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kai Huang
> 
>

Reply via email to