-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51564/#review147681
-----------------------------------------------------------


Ship it!





src/main/python/apache/aurora/executor/common/sandbox.py (line 251)
<https://reviews.apache.org/r/51564/#comment214894>

    You might extract this as a helper function (`_entity_exists(returncode: 
int): bool`) but definitely use a tuple instead of a list to represent the 
immutable set.  Extracting just the set would do the trick, ~:
    ```python
    # Return codes from `useradd` and `groupadd` calls.
    _USER_OR_GROUP_EXISTS = (
      4,  # uid/gid already exists.
      9   # user/group name exists.
    )
    ```


- John Sirois


On Sept. 2, 2016, 8:11 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51564/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2016, 8:11 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Bugs: AURORA-1761
>     https://issues.apache.org/jira/browse/AURORA-1761
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow E_NAME_IN_USE in useradd/groupadd.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> a172691e164cf64792f65f049d698f9758336542 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> 57ab39e2444100c3a689bb0ff745c62f7bc2f1a6 
> 
> Diff: https://reviews.apache.org/r/51564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Reply via email to