----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51662/#review148128 -----------------------------------------------------------
Please add a line to RELEASE_NOTES.md about this change. src/main/python/apache/aurora/admin/admin.py (line 351) <https://reviews.apache.org/r/51662/#comment215568> `settings.explicitBatchSize` lacks context in the help output of an admin client command. This should probably say it defaults to the value of the scheduler's `-reconciliation_explicit_batch_size` flag? src/main/python/apache/aurora/admin/admin.py (lines 357 - 358) <https://reviews.apache.org/r/51662/#comment215569> What if type is `foo`, etc? We should ensure the value is valid rather than defaulting to explicit reconciliation. src/main/python/apache/aurora/client/api/__init__.py (line 357) <https://reviews.apache.org/r/51662/#comment215570> move to previous line. - Joshua Cohen On Sept. 8, 2016, 12:30 a.m., Karthik Anantha Padmanabhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51662/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 12:30 a.m.) > > > Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > AURORA-1602 Aurora admin commands for reconcilation > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > c5765b70501c101f0535b4eed94e9948c36808f9 > > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java > 3275d72a0a74909e635bce615e2036ec72aa38ee > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 929d021a336c6a3438613c9340c84a1096dc9069 > src/main/python/apache/aurora/admin/admin.py > 76009b9c1c7a130c25abad544a176dc590dafb12 > src/main/python/apache/aurora/client/api/__init__.py > 9149c3018ae58d405f284fcbd4076d251ccc8192 > > src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java > b9317dc20456f90057ec2bf4d10619a5ae986187 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 779dc302602ae8842084807ca868a491ea99b676 > src/test/python/apache/aurora/admin/test_admin.py > eb193c4a33f5275f05a995338446bec0e19bc1cf > src/test/python/apache/aurora/client/api/test_scheduler_client.py > afac2500551af2fce406bb906aa4e33f353e90a1 > > Diff: https://reviews.apache.org/r/51662/diff/ > > > Testing > ------- > > * Manually tested on my local vagrant installation > * ./build-support/jenkins/build.sh > > > Thanks, > > Karthik Anantha Padmanabhan > >