> On Sept. 8, 2016, 9:37 a.m., Maxim Khutornenko wrote:
> > This will most certainly break the UI. The client needs to be updated as 
> > well to pass both (old and new) arguments. Please, test in vagrant with 
> > different combinations of scheduler and client versions.

I have validated that an old client can call the new scheduler. The deprecation 
message in the scheduler is printed out:
````
vagrant@aurora:~$ aurora update info devcluster/www-data/prod/hello 
85fc8af6-2242-43e3-80d3-1e7d9c6b6e42
 INFO] The key argument is deprecated, use the query argument instead
Job: devcluster/www-data/prod/hello, UpdateID: 
85fc8af6-2242-43e3-80d3-1e7d9c6b6e42
Started 2016-09-08T23:22:32, last activity: 2016-09-08T23:23:19
Current status: ROLLED_FORWARD
Update events:
  Status: ROLLING_FORWARD at 2016-09-08T23:22:32
  Status: ROLLED_FORWARD at 2016-09-08T23:23:19
Instance events:
  Instance 0 at 2016-09-08T23:22:32: INSTANCE_UPDATING
  Instance 0 at 2016-09-08T23:23:19: INSTANCE_UPDATED
````

I have not yet updated the JS code or the client code to use the query 
parameter to prevent deployment ordering issues.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51712/#review148208
-----------------------------------------------------------


On Sept. 7, 2016, 5:03 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51712/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 5:03 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1764
>     https://issues.apache.org/jira/browse/AURORA-1764
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This extends getJobUpdateDetails to return a list of details instead of being 
> scoped to a single update.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md d79aaadc197697d09a71c83494a01765d6a983d4 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 4202f0eec59ef16668fca6b6ebb925335ad5dea1 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  a7d1f74acdfe5f58eb822a4d826e920cad53dced 
> 
> Diff: https://reviews.apache.org/r/51712/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to