-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51662/#review148292
-----------------------------------------------------------



Overall LGTM, just some missing tests and missing error handling.


src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
(line 125)
<https://reviews.apache.org/r/51662/#comment215773>

    This smells to me and seems awkward. I guess this stemms from the fact that 
the `I*` wrappers don't have Optional fields for integers. Instead of this 
here, why not have the signature be 
`triggerExplicitReconciliation(Optional<Integer> batchSize)`?
    
    You can then do `int trueBatchSize = 
batchSize.orElse(settings.explicitBatchSize)`.
    
    You can then push validation of the value to the RPC/API layer.



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
(line 639)
<https://reviews.apache.org/r/51662/#comment215774>

    As mentioned above, we should do validation of the arguments here so we can 
return a usefull error message if it is invalid. This includes `0` and negative 
values.



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 (line 1258)
<https://reviews.apache.org/r/51662/#comment215776>

    Please add tests for cases where batch size is unset and when it is 0 and 
when it is negative.


- Zameer Manji


On Sept. 8, 2016, 5:01 p.m., Karthik Anantha Padmanabhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51662/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 5:01 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1602 Aurora admin commands for reconcilation
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md bbf7198dc7ce53bb02a1bc59f75a661e23472913 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> 3275d72a0a74909e635bce615e2036ec72aa38ee 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   src/main/python/apache/aurora/admin/admin.py 
> 76009b9c1c7a130c25abad544a176dc590dafb12 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 9149c3018ae58d405f284fcbd4076d251ccc8192 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  b9317dc20456f90057ec2bf4d10619a5ae986187 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  779dc302602ae8842084807ca868a491ea99b676 
>   src/test/python/apache/aurora/admin/test_admin.py 
> eb193c4a33f5275f05a995338446bec0e19bc1cf 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> afac2500551af2fce406bb906aa4e33f353e90a1 
> 
> Diff: https://reviews.apache.org/r/51662/diff/
> 
> 
> Testing
> -------
> 
> * Manually tested on my local vagrant installation
> * ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Karthik Anantha Padmanabhan
> 
>

Reply via email to