> On Sept. 12, 2016, 7:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/__init__.py, line 264 > > <https://reviews.apache.org/r/51712/diff/4/?file=1497099#file1497099line264> > > > > Why not going all the way to the client command and initializing both > > values in this changelist? Otherwise, there is a risk of cutting a release > > in between and delaying removal by extra release (until both client and > > scheduler are dual writing/reading). > > Zameer Manji wrote: > We can't send both values (it doesn't make sense). I will upgrade the > client to send the query object instead of the key object. I was not aware > when we made an API change we would also change the clients in the same > commit. > > Zameer Manji wrote: > Actually never mind, if I make this change (updating the client) it will > force us to deploy the client and the scheduler together. I think we need to > keep it as is for now right?
> We can't send both values (it doesn't make sense). This will work just fine. The newer scheduler will prefer the query (and collection in the response), while the old one will continue using the key completely unaware of the new value (thrift drops unknown fields). This way no functional changes will be needed on the client side, just removal of the deprecated fields. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148565 ----------------------------------------------------------- On Sept. 12, 2016, 7:39 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51712/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 7:39 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1764 > https://issues.apache.org/jira/browse/AURORA-1764 > > > Repository: aurora > > > Description > ------- > > This extends getJobUpdateDetails to return a list of details instead of being > scoped to a single update. > > > Diffs > ----- > > RELEASE-NOTES.md bbf7198dc7ce53bb02a1bc59f75a661e23472913 > api/src/main/thrift/org/apache/aurora/gen/api.thrift > c5765b70501c101f0535b4eed94e9948c36808f9 > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java > 4202f0eec59ef16668fca6b6ebb925335ad5dea1 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 929d021a336c6a3438613c9340c84a1096dc9069 > src/main/python/apache/aurora/client/api/__init__.py > 9149c3018ae58d405f284fcbd4076d251ccc8192 > src/main/resources/scheduler/assets/js/services.js > 315fc17894c2261333715fbb9c45fc02505f2942 > > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java > a7d1f74acdfe5f58eb822a4d826e920cad53dced > src/test/python/apache/aurora/client/api/test_api.py > 7a0797d5402e931006d4f215e2d9c0dbbd113257 > > Diff: https://reviews.apache.org/r/51712/diff/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > >
