----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148755 -----------------------------------------------------------
Master (f0ff1c4) is red with this patch. ./build-support/jenkins/build.sh Running setup.py bdist_wheel for cov-core: finished with status 'done' Stored in directory: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/86/e1/c2/9ff8cfe9773ce07003f2c2be096e169af4614c2f634671d49b Running setup.py bdist_wheel for twitter.common.options: started Running setup.py bdist_wheel for twitter.common.options: finished with status 'done' Stored in directory: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/60/c2/40/54b323809df9598cc125f02527f93ff743cd9bd979f4a1737d Successfully built pantsbuild.pants ansicolors setproctitle twitter.common.collections pathspec twitter.common.dirutil pystache scandir psutil pywatchman Markdown Pygments docutils twitter.common.confluence coverage pytest pytest-cov lmdb twitter.common.lang twitter.common.log cov-core twitter.common.options Installing collected packages: ansicolors, setproctitle, twitter.common.lang, twitter.common.collections, six, pathspec, twitter.common.dirutil, requests, pystache, scandir, psutil, pywatchman, futures, setuptools, pex, Markdown, Pygments, docutils, twitter.common.options, twitter.common.log, twitter.common.confluence, monotonic, fasteners, coverage, py, pytest, cov-core, pytest-cov, lmdb, pantsbuild.pants Found existing installation: setuptools 21.2.1 Uninstalling setuptools-21.2.1: Successfully uninstalled setuptools-21.2.1 Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10 psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7 twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7 twitter.common.lang-0.3.7 twitter.common.log-0.3.7 twitter.common.options-0.3.7 18:28:13 00:00 [main] (To run a reporting server: ./pants server) 18:28:13 00:00 [setup] 18:28:13 00:00 [parse][32m Executing tasks in goals: compile[0m 18:28:13 00:00 [compile] 18:28:13 00:00 [compile-prep-command] 18:28:13 00:00 [compile] 18:28:13 00:00 [python-eval] 18:28:13 00:00 [pythonstyle] 18:28:14 00:01 [cache] [32m No cached artifacts for 42 targets.[0m[32m Invalidated 42 targets.[0m T100:ERROR src/main/python/apache/aurora/client/cli/update.py:531 Indentation of 4 instead of 2 | if len(detailsList) == 0: T100:ERROR src/main/python/apache/aurora/client/cli/update.py:532 Indentation of 4 instead of 2 | context.print_err("There is no update for key: %s" % key) T100:ERROR src/main/python/apache/aurora/client/cli/update.py:537 Indentation of 4 instead of 2 | details = response.result.getJobUpdateDetailsResult.details FAILURE: 3 Python Style issues found 18:28:36 00:23 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 13, 2016, 6:19 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51712/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 6:19 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1764 > https://issues.apache.org/jira/browse/AURORA-1764 > > > Repository: aurora > > > Description > ------- > > This extends getJobUpdateDetails to return a list of details instead of being > scoped to a single update. > > > Diffs > ----- > > RELEASE-NOTES.md 4476d52c9e2363342d0c22c7d136e0e481633686 > api/src/main/thrift/org/apache/aurora/gen/api.thrift > c5765b70501c101f0535b4eed94e9948c36808f9 > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java > 4202f0eec59ef16668fca6b6ebb925335ad5dea1 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 929d021a336c6a3438613c9340c84a1096dc9069 > src/main/python/apache/aurora/client/api/__init__.py > 9149c3018ae58d405f284fcbd4076d251ccc8192 > src/main/python/apache/aurora/client/cli/update.py > d23243dcf93dd82f66b4c8cc4342bd2c8d2adc79 > src/main/resources/scheduler/assets/js/services.js > 315fc17894c2261333715fbb9c45fc02505f2942 > > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java > a7d1f74acdfe5f58eb822a4d826e920cad53dced > src/test/python/apache/aurora/client/api/test_api.py > 7a0797d5402e931006d4f215e2d9c0dbbd113257 > src/test/python/apache/aurora/client/cli/test_supdate.py > 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 > > Diff: https://reviews.apache.org/r/51712/diff/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > >