-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51384/
-----------------------------------------------------------

(Updated Sept. 13, 2016, 4:06 p.m.)


Review request for Aurora, David McLaughlin, Joshua Cohen, and Maxim 
Khutornenko.


Changes
-------

Rebasing the commit.
- Re-ran ./build-support/jenkins/build.sh and ./pants test 
src/test/python/apache/aurora/client/cli:cli


Bugs: AURORA-1711
    https://issues.apache.org/jira/browse/AURORA-1711


Repository: aurora


Description
-------

Allow custom metadata to be stored with the job updates. This feature
is to help case the reconciliation on job update request on the clients.

Today when a client's requests are proxied via a middle-man,
if the middle-man times out before the scheduler responds with success,
the client is left the only option of retry. In the case of updates,
since multiple updates are not allowed in parallel, the retries fail,
with INVALID_REQUEST. Although the original update is already accepted
by the scheduler and is in-progress.

With this feature, clients can reconcile the job updates,
- by marking updates them with a unique id in the metadata field
- scheduler returns the in-progress job update in its response
- client can match the client-generated ids to reconcile its state.


Diffs (updated)
-----

  RELEASE-NOTES.md 23e8168bd9bf792c8171ee4a1e856b95828c9a6a 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
ca014f350fa868a03835a2973020b715cf0f9fd8 
  src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 
f4f8d0037751c9c2096747264c19f6292461b308 
  src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 
e5228ae9baadb8cad1e5ce143df09426d6107583 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
d2673e6b328cb1e249fbe91d18e0d9e935636eaa 
  
src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
 a3b04949f1726f110638e4f93ef45947cdb9e7f8 
  
src/main/java/org/apache/aurora/scheduler/storage/db/migration/V008_CreateUpdateMetadataTable.java
 PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
26c45fd9cefe8a3e13746d9b00c289618a402999 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
594bb6219294dcc77d48dcad14e2a6f9caa0c534 
  
src/main/java/org/apache/aurora/scheduler/updater/UpdateInProgressException.java
 PRE-CREATION 
  src/main/python/apache/aurora/client/api/__init__.py 
f8b9690ab55fcc1cf81c9c4418aee5e5f3c42ed7 
  src/main/python/apache/aurora/client/cli/update.py 
a634c44468aa8e23488b8bf829c19f05f3f7e5a5 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
542f165add0f1d01a782fe6d6089bff3e736fb82 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
 8563630a179cb6d1e3b0e22c730ccbfe1c9291e2 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
a40830fd668aa650c22a48cbc757b45aef27e961 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 
08530397ff75081bde6f07f9d53317b5486e0da4 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
7935432b026921e854702c7c49eb4f159eec2b45 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 fa32750b667f435919c338e37652a768b24bc8e6 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
196df4754b553f05e50b66ad2f84271901bc9eba 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
2dfee1f6b69ca9d56afe8e1e20d150a9178206ee 
  src/test/python/apache/aurora/client/cli/util.py 
aac9f9c802e4ad1f06cee8cf3f56749760b33af5 

Diff: https://reviews.apache.org/r/51384/diff/


Testing
-------

./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
./pants test src/test/python/apache/aurora/client/cli:cli


Thanks,

Santhosh Kumar Shanmugham

Reply via email to