-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51899/#review149056
-----------------------------------------------------------




src/main/python/apache/aurora/common/health_check/shell.py (line 73)
<https://reviews.apache.org/r/51899/#comment216594>

    You pass in `_cmd` and `_isolator_fn` into the `ShellHealthCheck`. Have you 
considered just passing the result of `isolator_fn(cmd)` into the 
`ShellHealthCheck`? Or is there a reason that this can only be done in 
`__call__`?



src/main/python/apache/thermos/common/process_util.py (lines 24 - 26)
<https://reviews.apache.org/r/51899/#comment216592>

    Sorry for bringing up that old thing again :-)
    
    I belive this is only needed because we set 'shell:true' below. Have you 
tested what happens if we 'shell:false'?
    
    When looking th `ps tree` one sees that we run `sh -c bash -c '....'` so 
that first sh is completely useless and we could probably eliminate it by 
setting shell to false.



src/main/python/apache/thermos/common/process_util.py (line 34)
<https://reviews.apache.org/r/51899/#comment216593>

    That is the line I was talking about.


- Stephan Erb


On Sept. 14, 2016, 10:49 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51899/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 10:49 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zhitao Li.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ensure shell health checkers running for tasks running under an isolated 
> fileystem are run within that filesystem.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/common/health_check/shell.py 
> 35750823553406a96282545066f1291c20347ffa 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 5211f28e4e6c0efd29d7d79058128adb71ec7da8 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 5fc845eceac6f0c048d7489fdc4c672b0c609ea0 
>   src/main/python/apache/thermos/common/BUILD 
> 879b812b6a262d6e13b64e662999dd436f039748 
>   src/main/python/apache/thermos/common/process_util.py PRE-CREATION 
>   src/main/python/apache/thermos/core/process.py 
> 2134d4ff05861d4eaee9bc7ea4763e76ce63288c 
>   src/test/python/apache/aurora/common/health_check/test_shell.py 
> 011464cbe1df00f2a56d4690176e7c2d0d3fd535 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> bb6ea69dd94298c5b8cf4d5f06d06eea7790d66e 
>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
> 290627f8bc38d31ae123cfd1cdd36e9291c2de18 
> 
> Diff: https://reviews.apache.org/r/51899/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> e2e tests
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to