-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51980/#review149527
-----------------------------------------------------------
Master (330e8ee) is red with this patch.
./build-support/jenkins/build.sh
[1m # Create file stdout for capturing output. We
can't use StringIO mock[0m
[1m # because TestProcess is running fork.[0m
[1m with open(os.path.join(td, 'sys_stdout'),
'w+') as stdout:[0m
[1m with open(os.path.join(td, 'sys_stderr'),
'w+') as stderr:[0m
[1m with mutable_sys():[0m
[1m sys.stdout, sys.stderr = stdout,
stderr[0m
[1m [0m
[1m p = TestProcess('process', 'echo hello
world; echo >&2 hello stderr', 0,[0m
[1m taskpath, sandbox,
logger_destination=LoggerDestination.BOTH)[0m
[1m p.start()[0m
[1m rc =
wait_for_rc(taskpath.getpath('process_checkpoint'))[0m
[1m [0m
[1m assert rc == 0[0m
[1m # Check log files were created in std
path with correct content[0m
[1m> assert_log_content(taskpath, 'stdout',
'hello world\n')[0m
src/test/python/apache/thermos/core/test_process.py:487:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
taskpath = <apache.thermos.common.path.TaskPath object at
0x7fbe799cfb10>
log_name = 'stdout'
expected_content = 'hello world\n'
[1m def assert_log_content(taskpath, log_name,
expected_content):[0m
[1m log =
taskpath.with_filename(log_name).getpath('process_logdir')[0m
[1m assert os.path.exists(log)[0m
[1m with open(log, 'r') as fp:[0m
[1m> assert fp.read() == expected_content[0m
[1m[31mE assert '' == 'hello world\n'[0m
[1m[31mE + hello world[0m
src/test/python/apache/thermos/core/test_process.py:313:
AssertionError
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 710 passed, 6 skipped, 1 warnings in
327.06 seconds [0m
FAILURE
19:09:25 06:10 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Sept. 19, 2016, 6:28 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51980/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2016, 6:28 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1772
> https://issues.apache.org/jira/browse/AURORA-1772
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is a refactor with addition of HttpClient injected into Webhook class as
> opposed to previous usage of lower level HtttpURLConnection objects.
> Additionally due to peformance issues, it is unncessary to POST entire task
> state to webhook endpoint on every scheduler restart so that is removed in
> this patch.
>
>
> Diffs
> -----
>
> build.gradle d5a3a7a3bdb8349de6fc01d4a6271b32d942e531
> src/main/java/org/apache/aurora/scheduler/events/Webhook.java
> e54aa19d67278fcb5586f07c399f09062f845a18
> src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java
> e4193f7518e66d210a6d5aae22a9f04e2d4984b3
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java
> eaa70533a64740c74cebf15739b7142e2d3a4d11
> src/main/resources/org/apache/aurora/scheduler/webhook.json
> 00787985510d7d415b8074bef06d28b635c78b09
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java
> 488eefd14c3e67a41a75c809397c8d19f83cc08a
>
> Diff: https://reviews.apache.org/r/51980/diff/
>
>
> Testing
> -------
>
> Part of reason for refactor is to allow easier testing so cleaner unit tests
> were added with more code coverage.
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
