----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52074/#review149869 -----------------------------------------------------------
src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java (lines 50 - 54) <https://reviews.apache.org/r/52074/#comment217606> Agreed. I have been told that Aurora's philosophy is convention first, so I'm following what has been set. - Dmitriy Shirchenko On Sept. 20, 2016, 7:14 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52074/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 7:14 p.m.) > > > Review request for Aurora, Maxim Khutornenko, Mehrdad Nurolahzade, and Zameer > Manji. > > > Bugs: AURORA-1776 > https://issues.apache.org/jira/browse/AURORA-1776 > > > Repository: aurora > > > Description > ------- > > Dynamic reservation requires us to use acceptOffers so this is in preparation > of that work. acceptOffers is the call to dynamically reserve resources. > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java > 1bfd8dbf3aec314aaeb89b756ea3a2049df8777a > src/main/java/org/apache/aurora/scheduler/mesos/Driver.java > 14481468926b82a9bad3ee78c85f176e8ba893e2 > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java > 41b9aab55aa439b13eba3545703ec97b44690444 > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > 925c025d21bf1d44e0c1d319f6653ecfa8899481 > src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java > a739bce1226d9435fa7d0b18e411064a4e78e49e > > Diff: https://reviews.apache.org/r/52074/diff/ > > > Testing > ------- > > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Dmitriy Shirchenko > >
