-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52276/#review150457
-----------------------------------------------------------




src/main/java/org/apache/aurora/scheduler/events/Webhook.java (line 81)
<https://reviews.apache.org/r/52276/#comment218445>

    Please leave a comment to explain what we are doing here. You can link to 
the documentation to explain that we need to consume the entity and ensure the 
response is closed to ensure the underlying connection is closed.


- Zameer Manji


On Sept. 26, 2016, 2:08 p.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52276/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 2:08 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1783
>     https://issues.apache.org/jira/browse/AURORA-1783
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Last refactoring of Webhook did not correctly close out connections so some 
> webhook requests would not complete.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java 
> 66c134488f159fc25cfb2c1755b8fa23fbbdb613 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
> 71aae983e9c2c34e106a931e4d25691977684b11 
>   src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
> 6f37baaefb2910e688d7df90f3e94fc282cfb6b6 
> 
> Diff: https://reviews.apache.org/r/52276/diff/
> 
> 
> Testing
> -------
> 
> Verified in vagrant + added unit tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Reply via email to