-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review150540
-----------------------------------------------------------



Thanks for tackling this, it'll be a nice quality of life improvement!


src/main/python/apache/aurora/client/cli/options.py (lines 118 - 120)
<https://reviews.apache.org/r/52300/#comment218549>

    Changing this here means that all commands that previously required an 
instance key rather than a job key will now work without one. A quick glance at 
the code indicates that this change will also affect the `aurora job add` 
command, which requires specifying an instance to use as a template for adding 
more task instances to the job. I'm not sure we want to make that change as 
part of this review, there's value in being explicit when adding task instances 
versus picking a random one to act as a template.
    
    How about changing `SshCommand` to specify `INSTANCES_SPEC_ARGUMENT` 
instead of `TASK_INSTANCE_ARGUMENT` which already allows for an optional 
instance spec?



src/main/python/apache/aurora/client/cli/task.py (line 120)
<https://reviews.apache.org/r/52300/#comment218550>

    Do you think we should require an instance a the command was specified? I'm 
concerned about the scenario where running the command has a side effect on the 
instance. For example, if you were to run `aurora task ssh cluster/role/env/job 
--command=touch .healthchecksnooze`, after this change, that would disable 
health checks on (from the user's perspective) an unknown instance.


- Joshua Cohen


On Sept. 27, 2016, 10:44 a.m., JING CHEN wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 10:44 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
>     https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Running task ssh without an instance should pick the greatest instance
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_options.py 
> f2aae5741611909d5a1700cb4da70dec313e00da 
> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> -------
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>

Reply via email to