----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52367/#review150783 -----------------------------------------------------------
Ship it! Ship It! - Zameer Manji On Sept. 28, 2016, 3:51 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52367/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 3:51 p.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Bugs: AURORA-1784 > https://issues.apache.org/jira/browse/AURORA-1784 > > > Repository: aurora > > > Description > ------- > > This pulls in a fix that went in in 1.2.0dev7 that expands the fetch > timeout for the thrift binary used for our python builds from 1 second > to 30. This should provide relief for a top cause of build flakiness. > > Release notes are here: http://pantsbuild.github.io/notes-master.html > > The latest has dependencies that use cffi which in turn depends on > libffi and so this is added to the Vagrant image. > > Additionally, the mesos slave `--executor_registration_timeout` is set > to 1 minute as a temporary workaround to alleviate flaky e2e test > failures related to: https://issues.apache.org/jira/browse/MESOS-6004. > > Vagrantfile > | 2 +- > build-support/packer/build.sh > | 1 + > examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout > | 1 + > pants.ini > | 2 +- > 4 files changed, 4 insertions(+), 2 deletions(-) > > > Diffs > ----- > > Vagrantfile 88613bfdcabd6ec305efdbc5d21511ad28710aef > build-support/packer/build.sh 7aed38f6345c18ff6d83bb3028acb88bf2935dc7 > examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout > PRE-CREATION > pants.ini 70db14b6bd8178dee21a6b8c70ea169917435f99 > > Diff: https://reviews.apache.org/r/52367/diff/ > > > Testing > ------- > > Locally green: > ``` > ./build-support/jenkins/build.sh > ./build-support/python/make-pycharm-virtualenv > vagrant destroy && ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
