-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52422/#review151017
-----------------------------------------------------------


Ship it!




Ship It!

- Joshua Cohen


On Sept. 30, 2016, 2:15 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52422/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 2:15 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1784
>     https://issues.apache.org/jira/browse/AURORA-1784
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use the aufs storage driver for better disk io perf and eliminate a
> high timeout workaround for slow container image copies.
> 
>  examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout 
> | 1 -
>  examples/vagrant/provision-dev-cluster.sh                                   
> | 5 +++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/mesos_config/etc_mesos-slave/executor_registration_timeout 
> 108b54e5fa5e3229376cb7250272120b48b4089d 
>   examples/vagrant/provision-dev-cluster.sh 
> 7a35971c7c2df6346018439ef98505d786454c54 
> 
> Diff: https://reviews.apache.org/r/52422/diff/
> 
> 
> Testing
> -------
> 
> Greater than 2x speed improvement on file ops in the steady state and
> copy timeouts in the executor now avoided.
> 
> Before:
> ```
> vagrant@aurora:~$ docker info 2>/dev/null | grep -E "Storage|loop"
> Storage Driver: devicemapper
>  Data file: /dev/loop0
>  Metadata file: /dev/loop1
>  Data loop file: /var/lib/docker/devicemapper/devicemapper/data
>  Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
> vagrant@aurora:~$ time docker run --rm python:2.7 /usr/bin/python -c 
> "print('Hello Storage Driver')"
> Hello Storage Driver
> 
> real  0m1.053s
> user  0m0.007s
> sys   0m0.010s
> ```
> 
> After:
> ```
> vagrant@aurora:~$ docker info 2>/dev/null | grep Storage
> Storage Driver: aufs
> vagrant@aurora:~$ time docker run --rm python:2.7 /usr/bin/python -c 
> "print('Hello Storage Driver')"
> Hello Storage Driver
> 
> real  0m0.413s
> user  0m0.006s
> sys   0m0.012s
> ```
> 
> NB: In this test, the active ingredient is `--rm` which removes the
> container, engaging the storage driver in a serious way.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to