-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52494/#review151259
-----------------------------------------------------------
Master (ed72b1b) is red with this patch.
./build-support/jenkins/build.sh
[1m # Create file stdout for capturing output. We
can't use StringIO mock[0m
[1m # because TestProcess is running fork.[0m
[1m with open(os.path.join(td, 'sys_stdout'),
'w+') as stdout:[0m
[1m with open(os.path.join(td, 'sys_stderr'),
'w+') as stderr:[0m
[1m with mutable_sys():[0m
[1m sys.stdout, sys.stderr = stdout,
stderr[0m
[1m [0m
[1m p = TestProcess('process', 'echo hello
world; echo >&2 hello stderr', 0,[0m
[1m taskpath, sandbox,
logger_destination=LoggerDestination.BOTH)[0m
[1m p.start()[0m
[1m rc =
wait_for_rc(taskpath.getpath('process_checkpoint'))[0m
[1m [0m
[1m assert rc == 0[0m
[1m # Check log files were created in std
path with correct content[0m
[1m> assert_log_content(taskpath, 'stdout',
'hello world\n')[0m
src/test/python/apache/thermos/core/test_process.py:487:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
taskpath = <apache.thermos.common.path.TaskPath object at
0x7f7baf5bc110>
log_name = 'stdout'
expected_content = 'hello world\n'
[1m def assert_log_content(taskpath, log_name,
expected_content):[0m
[1m log =
taskpath.with_filename(log_name).getpath('process_logdir')[0m
[1m assert os.path.exists(log)[0m
[1m with open(log, 'r') as fp:[0m
[1m> assert fp.read() == expected_content[0m
[1m[31mE assert '' == 'hello world\n'[0m
[1m[31mE + hello world[0m
src/test/python/apache/thermos/core/test_process.py:313:
AssertionError
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 716 passed, 6 skipped, 1 warnings in
230.82 seconds [0m
FAILURE
23:50:35 04:15 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Oct. 3, 2016, 10:45 p.m., Pradyumna Kaushik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52494/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2016, 10:45 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added the 'reason' to the /pendingTasks endpoint. Made addPendingReason(...)
> a public method of NearestFit, as was suggested before and TaskGroups.java no
> longer accesses NearestFit functionality. I am using com.google.Gson to
> marshall the results into a JSON. I know this is not the ideal solution but I
> was getting the following exception during marshalling,
> ```"codehaus.JSONMappingException: union is current set to ..." ```
> , possibly due to a conflict between fasterxml and codehaus, and tried really
> hard to fix it but unfortunately was not able to. I wanted to get this patch
> out soon and hence, I created the workaround. I would love it if someone
> could give me a tip to fix the issue so that I can then incorporate that and
> submit another patch.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java
> c80e0c8adf80e12082a6952ae79b7d9cc960c5b6
> src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java
> f783e7ff220573915524a1efc27141193d19fa6c
> src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java
> 5d319557057e27fd5fc6d3e553e9ca9139399c50
>
> Diff: https://reviews.apache.org/r/52494/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Pradyumna Kaushik
>
>
