> On Oct. 5, 2016, 3:13 p.m., Aurora ReviewBot wrote:
> > Master (640f07b) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > [1m # Create file stdout for capturing output.
> > We can't use StringIO mock[0m
> > [1m # because TestProcess is running fork.[0m
> > [1m with open(os.path.join(td, 'sys_stdout'),
> > 'w+') as stdout:[0m
> > [1m with open(os.path.join(td,
> > 'sys_stderr'), 'w+') as stderr:[0m
> > [1m with mutable_sys():[0m
> > [1m sys.stdout, sys.stderr = stdout,
> > stderr[0m
> > [1m [0m
> > [1m p = TestProcess('process', 'echo
> > hello world; echo >&2 hello stderr', 0,[0m
> > [1m taskpath, sandbox,
> > logger_destination=LoggerDestination.BOTH)[0m
> > [1m p.start()[0m
> > [1m rc =
> > wait_for_rc(taskpath.getpath('process_checkpoint'))[0m
> > [1m [0m
> > [1m assert rc == 0[0m
> > [1m # Check log files were created in
> > std path with correct content[0m
> > [1m> assert_log_content(taskpath,
> > 'stdout', 'hello world\n')[0m
> >
> >
> > src/test/python/apache/thermos/core/test_process.py:487:
> > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> >
> > taskpath = <apache.thermos.common.path.TaskPath object
> > at 0x7f7ded54f150>
> > log_name = 'stdout'
> > expected_content = 'hello world\n'
> >
> > [1m def assert_log_content(taskpath, log_name,
> > expected_content):[0m
> > [1m log =
> > taskpath.with_filename(log_name).getpath('process_logdir')[0m
> > [1m assert os.path.exists(log)[0m
> > [1m with open(log, 'r') as fp:[0m
> > [1m> assert fp.read() == expected_content[0m
> > [1m[31mE assert '' == 'hello world\n'[0m
> > [1m[31mE + hello world[0m
> >
> >
> > src/test/python/apache/thermos/core/test_process.py:313: AssertionError
> > generated xml file:
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
> >
> > [1m[31m 1 failed, 716 passed, 6 skipped, 1 warnings
> > in 235.81 seconds [0m
> >
> > FAILURE
> >
> >
> > 22:12:25 04:31 [complete][31m
> > FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
>
> Santhosh Kumar Shanmugham wrote:
> How do we debug these kind of failures? This same failure happened for me
> as well. Is this some flakiness that was introduced recently?
I want to blame the Apache Jenkins infrastructure but I have no idea what's
causing these.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/#review151573
-----------------------------------------------------------
On Oct. 5, 2016, 3:01 p.m., Kai Huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52453/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 3:01 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-894
> https://issues.apache.org/jira/browse/AURORA-894
>
>
> Repository: aurora
>
>
> Description
> -------
>
> - Add support for receiving a new HealthCheckConfig attribute
> "min_consecutive_successes" in health checker.
> - Add an entry in release note that describes the health check driven update
> feature.
>
> This patch is related to https://reviews.apache.org/r/52094/, in which I
> added a new configuration value "min_consecutive_successes" in
> HealthCheckConfig.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 97f05d52cfd2ed481feae0d01172b5b1af72b80a
> docs/features/job-updates.md 792f2ae5fd14b1ea9af8be000629ce5a7fc2fe8f
> src/main/python/apache/aurora/client/api/updater_util.py
> c649316edb876565c92cc90c9f030e153c008924
> src/main/python/apache/aurora/executor/common/health_checker.py
> 03fbffdc3862a94c2ba42c9b9e8f2be4094129b8
>
> Diff: https://reviews.apache.org/r/52453/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
> ./pants test.pytest src/test/python/apache/aurora/executor::
>
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Kai Huang
>
>
