----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/#review151677 -----------------------------------------------------------
Master (fdb536a) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 6, 2016, 4:26 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52594/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 4:26 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > ------- > > Remove unused code and restrict visibility where possible. Also fix up > various warnings. > > build.gradle > | 13 +- > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java > | 372 > -------------------------------------------------- > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java > | 167 > ---------------------- > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java > | 140 ------------------- > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java > | 210 > ---------------------------- > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java > | 139 > ------------------- > config/findbugs/excludeFilter.xml > | 8 ++ > docs/features/service-discovery.md > | 2 +- > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > | 6 +- > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > | 4 +- > {commons/src/main/java/org/apache/aurora/common/zookeeper => > src/main/java/org/apache/aurora/scheduler/discovery}/Credentials.java > | 30 ++-- > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java > | 6 +- > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java > | 1 - > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java > | 1 - > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java > | 8 +- > {commons/src/main/java/org/apache/aurora/common/zookeeper => > src/main/java/org/apache/aurora/scheduler/discovery}/JsonCodec.java > | 8 +- > > src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java > | 7 +- > src/main/java/org/apache/aurora/scheduler/{app => > discovery}/ServiceGroupMonitor.java > | 4 +- > {commons/src/main/java/org/apache/aurora/common/zookeeper => > src/main/java/org/apache/aurora/scheduler/discovery}/SingletonService.java > | 10 +- > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java > | 9 +- > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java > | 51 +++++++ > .../src/main/java/org/apache/aurora/common/zookeeper => > src/main/java/org/apache/aurora/scheduler/discovery}/testing/BaseZooKeeperTest.java > | 9 +- > .../src/main/java/org/apache/aurora/common/zookeeper => > src/main/java/org/apache/aurora/scheduler/discovery}/testing/ZooKeeperTestServer.java > | 22 +-- > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > | 2 +- > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java > | 4 +- > > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java > | 4 +- > src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java > | 4 +- > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > | 7 +- > > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java > | 4 +- > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorDiscoveryModuleTest.java > | 6 +- > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java > | 2 - > {commons/src/test/java/org/apache/aurora/common/zookeeper => > src/test/java/org/apache/aurora/scheduler/discovery}/JsonCodecTest.java > | 6 +- > src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java > | 12 +- > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java > | 15 +- > src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java > | 4 +- > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > | 2 +- > 36 files changed, 153 insertions(+), 1146 deletions(-) > > > Diffs > ----- > > build.gradle 07689f940f727794849ed1b87b042adbeea57608 > commons/src/main/java/org/apache/aurora/common/zookeeper/Credentials.java > 18319a3e59dae41e89e808b09fc9ae1c5e282b89 > commons/src/main/java/org/apache/aurora/common/zookeeper/JsonCodec.java > 45e789bb66863dd766392e5f642bde1e27397b56 > > commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java > 7f962eb84cc5b651dd731bbbfb021d5d96bf9e3a > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java > ce243fb44266b741ff3f14eb5438ff38cf46133f > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java > 2ada2646da7bdc3276803336cc638e23b9e61d26 > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java > ba09279be9d8bfde79b7610a184bb472ab0396b5 > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperTest.java > 0e6898728c7413f9929124c3a371b98da9ab6e9d > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 50acaeba82e163f8f2970a264cbd889c9eb3b5ed > commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java > a37808ce02dccb9e15a756dadafc8021deac93f6 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java > 5eee235162e938ecdfdb7d3c4d31d848a34a648b > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java > 9e482a6162abe5f9864d0ca0094cd97dc8036496 > config/findbugs/excludeFilter.xml fe3f4ca5db1484124af14421a3349950dfec8519 > docs/features/service-discovery.md 36823c8ee8fc872a3e28fe8861d489a45ad9021b > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > 195ab9137c078438d3f7d8b7fd859c26fad27358 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 94c1a29de4cd72be213c999239c9cef461cab4f0 > src/main/java/org/apache/aurora/scheduler/app/ServiceGroupMonitor.java > a1329fd5010fadbf6bceeb2ae0476a6261830492 > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java > 6ccfef4c49b6c5da0431b903b9966bcf88af5634 > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java > 0b86fb6eb95d74a464358e8c1fcd473b52a9afbc > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java > c9bd1eb9a0a1a996e548d6cfae95e72779fd4872 > > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java > c3a524f86229aaf51312c21932583538fbe5fc8d > > src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java > 07bce962093c9a48476386b8335555b61a23d080 > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java > e1dc57ef7a42e8314161a5d073d186036df26680 > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 7bf8185695ab0af799ee297f39bcd79f6546cf6b > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java > 9bf6f5282b3006b972f618021e7abe32bfb6d30f > > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java > 6704a328a4023a178ed8f86ae4772cb04eb2fa8e > src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java > 051c520b4cb4cc1046dc316dfc8e1c968fc4e8e4 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 1eabb8962e64c6687ef3293aef2918794a72f5a2 > > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java > eb8c114c55143eff948412d1452b2eeab50995c4 > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorDiscoveryModuleTest.java > ea4570a96e0ce96ef4d2e054cb7ef7e71e631ae7 > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java > a860eded4956e9997127fb0a2d007ae96924f13f > > src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java > d45dbb5afa7ee1197c624860f76a7398cdcc35a7 > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java > fb03f25833587cb823464eecb2c7e5ed6172b9ca > src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java > a16058f32306332f3d37aae1e25dece86c3fa8cc > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > 3caad32a30a02a1dd33893266c0dc817633a0f37 > > Diff: https://reviews.apache.org/r/52594/diff/ > > > Testing > ------- > > Locally green: > ``` > ./gradlew -Pq build > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
