-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52777/#review152291
-----------------------------------------------------------


Ship it!




Your testing done says this is enough on the aurora-packaging side, but on the 
[aurora side](https://github.com/apache/aurora/blob/master/build.gradle#L24) 
the installed plugin probably also needs to be changed from from 'application' 
to 'distribition' at which point I'm not immediately sure how the [main class 
name](https://github.com/apache/aurora/blob/master/build.gradle#L586) is 
configured in the new regime (maybe the same).

- John Sirois


On Oct. 12, 2016, 4:13 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52777/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 4:13 a.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> The latter was deprecated and finally removed in Gradle 3.0: 
> 
> "The installApp task is no longer created by the application plugin
> (use installDist instead)." 
> 
> https://docs.gradle.org/3.0/release-notes
> 
> 
> Diffs
> -----
> 
>   specs/debian/rules fc74d1c8c0fd3251828dd2d237ac4ee950a41e42 
> 
> Diff: https://reviews.apache.org/r/52777/diff/
> 
> 
> Testing
> -------
> 
> ./build-artifact.sh  builder/rpm/centos-7 snapshot.tar.gz 0.17-snapshot
> ./build-artifact.sh  builder/deb/ubuntu-trusty snapshot.tar.gz 0.17-snapshot
> ./build-artifact.sh  builder/deb/debian-jessie snapshot.tar.gz 0.17-snapshot
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to