> On Oct. 12, 2016, 7:48 p.m., David McLaughlin wrote: > > Thanks for doing this! > > > > Could you add a test for this? Looking in test_task_runner.py, it looks > > like unfortunately the provider class lacks any sort of coverage. A minimal > > test here could be to just test the path through > > Provider.from_assigned_task that you've altered here?
+1. Change looks good to me, but please add a test case. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152385 ----------------------------------------------------------- On Oct. 12, 2016, 7:42 p.m., Justin Pinkul wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52804/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 7:42 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1789 > https://issues.apache.org/jira/browse/AURORA-1789 > > > Repository: aurora > > > Description > ------- > > Adding an error message when the mesos_containerizer_path is not set > correctly. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/thermos_task_runner.py > efa51e162de28c9d96fc898b87a1f63843928829 > > Diff: https://reviews.apache.org/r/52804/diff/ > > > Testing > ------- > > I verified the new error makes its way to the UI when > mesos_containerizer_path is set to a file that does not exist and also > verified the executors complates succesfully when mesos_containerizer_path is > set to the correct location. > > Unit tests: > ``` > ./pants test src/test/python/apache/thermos:: > ./pants test src/test/python/apache/aurora/executor:: > ``` > > > Thanks, > > Justin Pinkul > >
