-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52821/#review152571
-----------------------------------------------------------




src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java (line 215)
<https://reviews.apache.org/r/52821/#comment221621>

    Is there a reason we can't apply the `get` call here rather than in the 
getter?


- Joshua Cohen


On Oct. 13, 2016, 9:27 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52821/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2016, 9:27 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1794
>     https://issues.apache.org/jira/browse/AURORA-1794
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The mentioned flag has been introduced in 
> https://reviews.apache.org/r/51807/. Unfortunately, as detailed in the bug 
> report, my testing was not thorough enough. 
> 
> Problem description:
> 
> * The flag is used the `ResourceType` enum constructor. This implies the flag 
> value needs to be available during class loading.
> * Values supplied via the scheduler command line are only set at runtime, 
> right at the beginning `main` [1].
> * Luckily, there is a check in our arg parsing library that warns if a value 
> is changed after it has already been read. In other words: We get an 
> exception if we change the flag, because it has already been read during 
> class loading.
> 
> This patch corrects this issue by treating the arguments as a supplier which 
> can be read lazily at runtime. The patch also extends the existing e2e test 
> for revocable resources to also consider RAM.
> 
> [1] 
> https://github.com/apache/aurora/blob/b417be38fe1fcae6b85f7e91cea961ab272adf3f/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java#L197
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 03349b0b687bade48a2d19712dcb63802f3ef273 
>   commons-args/src/main/java/org/apache/aurora/common/args/Arg.java 
> 8e915c6233428ca35d3ee11ea8d7b7c008a88568 
>   examples/vagrant/mesos_config/etc_mesos-slave/modules 
> 4352bcad8022e9a82fe1e13744a02d1105e52fe9 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 4d88881f0c6a53e995f845512b64b4f78e0a5a72 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java 
> c49fd06cd11f4269b5c0b25014d22707c513fa5d 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> e1a5dcef726f021df89bccb7e81e63fe60336009 
> 
> Diff: https://reviews.apache.org/r/52821/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to