> On Oct. 13, 2016, 7:10 p.m., Santhosh Kumar Shanmugham wrote:
> > src/test/python/apache/aurora/common/test_cookie_auth_module.py, line 18
> > <https://reviews.apache.org/r/51893/diff/14/?file=1530523#file1530523line18>
> >
> >     Can we also have a negative test case, where the COOKIE auth fails when 
> > the cookie jar is absent?

Done.


> On Oct. 13, 2016, 7:10 p.m., Santhosh Kumar Shanmugham wrote:
> > docs/operations/security.md, line 203
> > <https://reviews.apache.org/r/51893/diff/14/?file=1530519#file1530519line203>
> >
> >     nit - s/cookied/cookie

Fixed.


- Giulio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/#review152557
-----------------------------------------------------------


On Oct. 14, 2016, 11:52 a.m., Giulio Eulisse wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51893/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2016, 11:52 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow cookie based authentication
> 
> This allows aurora client to connect to servers which are behind a frontend 
> which expects some sort of cookie to autheticate and authorize users. The 
> cookie should be stored in MozillanCookieJar format in a file named 
> `~/.aurora-token`.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> fbebbab8c827b5695042d18770d850e31fc38122 
>   src/main/python/apache/aurora/client/cli/client.py 
> fa0c2648c5ff7ea6c9d949cf8cd9b9795d452e98 
>   src/main/python/apache/aurora/common/cookie_auth_module.py PRE-CREATION 
>   src/test/python/apache/aurora/common/test_cookie_auth_module.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51893/diff/
> 
> 
> Testing
> -------
> 
> $ cat ~/aurora/clusters.json
> [
> {
>   "name": "build",
>   "scheduler_uri": "https://aliaurora.cern.ch";,
>   "auth_mechanism": "COOKIE"
> }
> ]
> $ dist/aurora.pex quota get build/root
> 
> 
> Thanks,
> 
> Giulio Eulisse
> 
>

Reply via email to