----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review152660 -----------------------------------------------------------
Master (8256000) is red with this patch. ./build-support/jenkins/build.sh [1m def test_cookie_auth_module(self):[0m [1m cam = CookieAuthModule()[0m [1m assert cam.mechanism is "COOKIE"[0m [1m> assert type(cam.auth()) is CookieAuth[0m src/test/python/apache/aurora/common/test_cookie_auth_module.py:43: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ .pants.d/python-setup/chroots/17ea8a21405a604e3a7551df7b625812f47d8a42/apache/aurora/common/cookie_auth_module.py:52: in auth [1m return CookieAuth()[0m _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <apache.aurora.common.cookie_auth_module.CookieAuth object at 0x7f9b7d22bc50> search_paths = ('/etc/aurora', '/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.aurora') [1m def __init__(self, search_paths=DEFAULT_SEARCH_PATHS):[0m [1m # setup any auth-related data here[0m [1m for search_path in search_paths:[0m [1m filename = join(search_path, 'auth-token')[0m [1m try:[0m [1m self.jar = cookielib.MozillaCookieJar(filename)[0m [1m self.jar.load()[0m [1m return[0m [1m except IOError:[0m [1m pass[0m [1m prettySearchPath = ", ".join(search_paths)[0m [1m errorMsg = "Could not find file `auth-token` in search paths:\n%s" % prettySearchPath[0m [1m> raise IOError(errorMsg)[0m [1m[31mE IOError: Could not find file `auth-token` in search paths:[0m [1m[31mE /etc/aurora, /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.aurora[0m .pants.d/python-setup/chroots/17ea8a21405a604e3a7551df7b625812f47d8a42/apache/aurora/common/cookie_auth_module.py:38: IOError generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml [1m[31m 1 failed, 717 passed, 6 skipped, 1 warnings in 244.89 seconds [0m FAILURE 12:14:29 04:33 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 14, 2016, 11:52 a.m., Giulio Eulisse wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51893/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 11:52 a.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > Allow cookie based authentication > > This allows aurora client to connect to servers which are behind a frontend > which expects some sort of cookie to autheticate and authorize users. The > cookie should be stored in MozillanCookieJar format in a file named > `~/.aurora-token`. > > > Diffs > ----- > > RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 > docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec > src/main/python/apache/aurora/admin/aurora_admin.py > fbebbab8c827b5695042d18770d850e31fc38122 > src/main/python/apache/aurora/client/cli/client.py > fa0c2648c5ff7ea6c9d949cf8cd9b9795d452e98 > src/main/python/apache/aurora/common/cookie_auth_module.py PRE-CREATION > src/test/python/apache/aurora/common/test_cookie_auth_module.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/51893/diff/ > > > Testing > ------- > > $ cat ~/aurora/clusters.json > [ > { > "name": "build", > "scheduler_uri": "https://aliaurora.cern.ch", > "auth_mechanism": "COOKIE" > } > ] > $ dist/aurora.pex quota get build/root > > > Thanks, > > Giulio Eulisse > >