Re: Review Request 52884: Document how to create a custom CLI build

[Aurora ReviewBot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52884/#review152681
-----------------------------------------------------------



Master (8256000) is red with this patch.
  ./build-support/jenkins/build.sh

                             # Create file stdout for capturing output. We 
can't use StringIO mock
                             # because TestProcess is running fork.
                             with open(os.path.join(td, 'sys_stdout'), 
'w+') as stdout:
                               with open(os.path.join(td, 'sys_stderr'), 
'w+') as stderr:
                                 with mutable_sys():
                                   sys.stdout, sys.stderr = stdout, 
stderr
                         
                                   p = TestProcess('process', 'echo hello 
world; echo >&2 hello stderr', 0,
                                                   taskpath, sandbox, 
logger_destination=LoggerDestination.BOTH)
                                   p.start()
                                   rc = 
wait_for_rc(taskpath.getpath('process_checkpoint'))
                         
                                   assert rc == 0
                                   # Check log files were created in std 
path with correct content
                     >             assert_log_content(taskpath, 'stdout', 
'hello world\n')
                     
                     src/test/python/apache/thermos/core/test_process.py:487: 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     taskpath = <apache.thermos.common.path.TaskPath object at 
0x7f41e8b2b0d0>
                     log_name = 'stdout'
                     expected_content = 'hello world\n'
                     
                         def assert_log_content(taskpath, log_name, 
expected_content):
                           log = 
taskpath.with_filename(log_name).getpath('process_logdir')
                           assert os.path.exists(log)
                           with open(log, 'r') as fp:
                     >       assert fp.read() == expected_content
                     E       assert '' == 'hello world\n'
                     E         + hello world
                     
                     src/test/python/apache/thermos/core/test_process.py:313: 
AssertionError
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
                      1 failed, 715 passed, 6 skipped, 1 warnings in 
219.52 seconds 
                     
FAILURE


15:15:51 04:08   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 14, 2016, 3:03 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52884/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2016, 3:03 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Giulio Eulisse, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Document how to create a custom pex that you can use to put 
> deployment-specific customizations.
> 
> I think the dependency section needs some work, but I'm not an expert on 
> pants and how it resolves dependencies. Currently we just have the forked 
> sources in the same repo, so we can point directly to the OSS build target. I 
> don't think we upload the aurora CLI to PyPi? So it's mostly an exercise left 
> to the user to make that dependency available in their repo. Can anyone help 
> fill out that section?
> 
> 
> Diffs
> -----
> 
>   docs/development/client.md 079c4712885a615716c3ecbd9a48581fc1bcee14 
> 
> Diff: https://reviews.apache.org/r/52884/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>