----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52915/#review152794 -----------------------------------------------------------
I really don't like being on .dev for our build tooling but the reported bug is very annoying. Plus, I am excited for the prospect of having pants consume `./thriftw` instead of pulling down it's own binary. - Zameer Manji On Oct. 15, 2016, 3:42 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52915/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2016, 3:42 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This gets rid of an impossible to work around warning emitted by every > pants invocation and prepares for consuming an upcoming pants change > that will allow Aurora to use the thrift binary selected by > `build-support/thrift/thriftw` consistently everywhere. > > Release notes are here: > http://www.pantsbuild.org/notes-master.html > > pants.ini | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > > Diffs > ----- > > pants.ini 6ed4186780c485f2d023d8e398429e570e9e5a0c > > Diff: https://reviews.apache.org/r/52915/diff/ > > > Testing > ------- > > Locally green: > ``` > ./build-support/jenkins/build.sh > ./build-support/python/make-pycharm-virtualenv > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
