-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52921/
-----------------------------------------------------------

(Updated Oct. 17, 2016, 1:04 a.m.)


Review request for Aurora.


Repository: aurora


Description (updated)
-------

I saw THRIFT-3868 and thought we could apply the same micro-optimization
as well. Details: https://github.com/apache/thrift/pull/1106

Example of a generated equals method (in ITaskConfig):

    @Override
    public boolean equals(Object o) {
      if (this == o) {
        return true;
      }
      if (!(o instanceof ITaskConfig)) {
        return false;
      }
      ITaskConfig other = (ITaskConfig) o;
      return Objects.equals(job, other.job)
          && Objects.equals(owner, other.owner)
          && Objects.equals(isService, other.isService)
          && Objects.equals(numCpus, other.numCpus)
          && Objects.equals(ramMb, other.ramMb)
          && Objects.equals(diskMb, other.diskMb)
          && Objects.equals(priority, other.priority)
          && Objects.equals(maxTaskFailures, other.maxTaskFailures)
          && Objects.equals(production, other.production)
          && Objects.equals(tier, other.tier)
          && Objects.equals(resources, other.resources)
          && Objects.equals(constraints, other.constraints)
          && Objects.equals(requestedPorts, other.requestedPorts)
          && Objects.equals(mesosFetcherUris, other.mesosFetcherUris)
          && Objects.equals(taskLinks, other.taskLinks)
          && Objects.equals(contactEmail, other.contactEmail)
          && Objects.equals(executorConfig, other.executorConfig)
          && Objects.equals(metadata, other.metadata)
          && Objects.equals(container, other.container);
    }


Diffs
-----

  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
7c281800b00b973351659ecacd5b7f6e55e46bba 

Diff: https://reviews.apache.org/r/52921/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Stephan Erb

Reply via email to