----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review153144 -----------------------------------------------------------
Ship it! Ship It! - Zameer Manji On Oct. 18, 2016, 11:22 a.m., Justin Pinkul wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52804/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 11:22 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1789 > https://issues.apache.org/jira/browse/AURORA-1789 > > > Repository: aurora > > > Description > ------- > > Adding an error message when the mesos_containerizer_path is not set > correctly. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/thermos_task_runner.py > efa51e162de28c9d96fc898b87a1f63843928829 > src/test/python/apache/aurora/executor/test_thermos_executor.py > 0bfe9e931f873c9f804f2ba4012e050e1f9fd24e > > Diff: https://reviews.apache.org/r/52804/diff/ > > > Testing > ------- > > I verified the new error makes its way to the UI when > mesos_containerizer_path is set to a file that does not exist and also > verified the executors complates succesfully when mesos_containerizer_path is > set to the correct location. > > Unit tests: > ``` > ./pants test src/test/python/apache/thermos:: > ./pants test src/test/python/apache/aurora/executor:: > ``` > > > Thanks, > > Justin Pinkul > >