----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53519/#review155099 -----------------------------------------------------------
Master (84bde07) is red with this patch. ./build-support/jenkins/build.sh virtualenv-15.0.2/virtualenv_embedded/python-config virtualenv-15.0.2/virtualenv_embedded/site.py virtualenv-15.0.2/virtualenv_support/ virtualenv-15.0.2/virtualenv_support/__init__.py virtualenv-15.0.2/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl virtualenv-15.0.2/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl virtualenv-15.0.2/virtualenv_support/setuptools-21.2.1-py2.py3-none-any.whl virtualenv-15.0.2/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl + touch virtualenv-15.0.2/BOOTSTRAPPED + popd /home/jenkins/jenkins-slave/workspace/AuroraBot + exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-15.0.2/virtualenv.py --no-download /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python Installing setuptools, pip, wheel...done. Collecting isort==4.0.0 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:318: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning. SNIMissingWarning /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning Downloading isort-4.0.0-py2.py3-none-any.whl Installing collected packages: isort Successfully installed isort-4.0.0 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning You are using pip version 8.1.2, however version 9.0.1 is available. You should consider upgrading via the 'pip install --upgrade pip' command. ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/task_observer.py Imports are incorrectly sorted. --- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/task_observer.py:before 2016-11-06 23:31:36.277804 +++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/task_observer.py:after 2016-11-06 23:37:39.116321 @@ -27,8 +27,8 @@ from twitter.common.lang import Lockable from twitter.common.quantity import Amount, Time +from apache.thermos.common.exceptional import ExceptionalThread from apache.thermos.common.path import TaskPath -from apache.thermos.common.exceptional import ExceptionalThread from apache.thermos.monitoring.monitor import TaskMonitor from apache.thermos.monitoring.process import ProcessSample from apache.thermos.monitoring.resource import ResourceMonitorBase, TaskResourceMonitor I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 6, 2016, 11:26 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53519/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2016, 11:26 p.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Bugs: AURORA-1801 > https://issues.apache.org/jira/browse/AURORA-1801 > > > Repository: aurora > > > Description > ------- > > I was not able to manually trigger the root cause of AURORA-1801 by altering > the Mesos filesystem layout. I have therefore adopted the general teardown > idea. This is a proof of concept. Feedback welcome. > > Example output (using a hardcoded throw): > > ``` > Bottle v0.11.6 server starting up (using CherryPyServer())... > Listening on http://192.168.33.7:1338/ > Hit Ctrl-C to quit. > > E1106 23:03:36.722500 8699 exceptional.py:41] Unhandled error in thread > Thread-1 [TID=8705]. Tearing down. > Traceback (most recent call last): > File "apache/thermos/common/exceptional.py", line 37, in _excepting_run > self.__real_run(*args, **kw) > File "apache/thermos/observer/task_observer.py", line 135, in run > self._detector.refresh() > File "apache/thermos/observer/detector.py", line 74, in refresh > self._refresh_detectors() > File "apache/thermos/observer/detector.py", line 58, in _refresh_detectors > new_paths = set(self._path_detector.get_paths()) > File "apache/aurora/executor/common/path_detector.py", line 35, in get_paths > return list(set(path for path in iterate() if os.path.exists(path))) > File "apache/aurora/executor/common/path_detector.py", line 35, in <genexpr> > return list(set(path for path in iterate() if os.path.exists(path))) > File "apache/aurora/executor/common/path_detector.py", line 34, in iterate > raise RuntimeError("Fail on purpose...") > RuntimeError: Fail on purpose... > I1106 23:03:42.513900 8728 static_assets.py:34] detecting assets... > I1106 23:03:42.541809 8728 static_assets.py:38] detected asset: observer.js > I1106 23:03:42.542799 8728 static_assets.py:38] detected asset: > bootstrap.css > I1106 23:03:42.543728 8728 static_assets.py:38] detected asset: > jquery.pailer.js > I1106 23:03:42.544576 8728 static_assets.py:38] detected asset: jquery.js > I1106 23:03:42.548482 8728 static_assets.py:38] detected asset: favicon.ico > Bottle v0.11.6 server starting up (using CherryPyServer())... > Listening on http://192.168.33.7:1338/ > Hit Ctrl-C to quit. > ``` > > Questions: > > * Is it a good idea to solve the teardown problem like that? > * Do we want to update all current usages of > `twitter.common.exceptions.ExceptionalThread`? > * Where do we put that code so that we can use it in client, executor and > observer? > > > Diffs > ----- > > src/main/python/apache/aurora/tools/thermos_observer.py > 0a07df7bed902be2b73d2ca3308a02a1e34760d6 > src/main/python/apache/thermos/common/BUILD > 0adabbfa3f0230dae95aca5002c128832916fdd6 > src/main/python/apache/thermos/common/exceptional.py PRE-CREATION > src/main/python/apache/thermos/observer/task_observer.py > 1485de8faef52716f11b82a3556064de26c67427 > > Diff: https://reviews.apache.org/r/53519/diff/ > > > Testing > ------- > > ./pants test.pytest src/{main,test}/python:: -- -v > aurorabuild observer > > > Thanks, > > Stephan Erb > >
