-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53836/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
Repository: aurora
Description
-------
This required an upgrade to the latest pants dev release to correct
an issue with the setup.py binary packager we use to generate sdists.
This is for sanity sake, and, once the TODO in
`build-support/thrift/prepare_binary.sh` is addressed, it will also
allow pants-patch-free addition of new platforms (thinking ARM).
api/src/main/thrift/org/apache/aurora/gen/BUILD | 3 +++
api/src/main/thrift/org/apache/thermos/BUILD | 1 +
build-support/thrift/.gitignore | 1 +
build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch | 42
+++++++++++++------------------
build-support/thrift/AURORA-1727.lib.py.setup.py.patch | 45
+++++++++++++++++++++++++++++++++
{api/src/main/thrift/org/apache/thermos => build-support/thrift}/BUILD | 18
++++---------
build-support/thrift/Makefile | 2 +-
build-support/thrift/prepare_binary.sh | 68
++++++++++++++++++++++++++++++++++++++++++++++++++
build-support/thrift/thriftw | 12
+++++++--
pants.ini | 7
+++++-
10 files changed, 158 insertions(+), 41 deletions(-)
Diffs
-----
api/src/main/thrift/org/apache/aurora/gen/BUILD
f4004a3ca36078c6d24991db4beb68903a05652c
api/src/main/thrift/org/apache/thermos/BUILD
cb655a2fd35d22f7d7e80c4311742bad763d8614
build-support/thrift/.gitignore 9a3adb69210ba3dbf3c1f408895561da37e8f4c3
build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch
b69e3fef137cd73c6f2b73201463a0705ef8082a
build-support/thrift/AURORA-1727.lib.py.setup.py.patch PRE-CREATION
build-support/thrift/BUILD PRE-CREATION
build-support/thrift/Makefile 48b174ad622288d2738a5fa37bbb72385fcc3a27
build-support/thrift/prepare_binary.sh PRE-CREATION
build-support/thrift/thriftw 50d6dfdeb16ca8bf14aaff7aa826e3d69c5e13f0
pants.ini cecdb277f327f77b2652f76a30fc8d4ffd9ff1db
Diff: https://reviews.apache.org/r/53836/diff/
Testing
-------
Locally green:
```
rm -rf ~/.cache/pants .cache/
git clean -fdx build-support/thrift
./pants clean-all
./build-support/jenkins/build.sh
vagrant ssh --command "rm -rf ~/.cache/pants && cd aurora && rm -rf .cache/ &&
./pants clean-all"
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
./build-support/python/make-pycharm-virtualenv
```
Thanks,
John Sirois
