-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53918/
-----------------------------------------------------------
(Updated Nov. 19, 2016, 10:36 a.m.)
Review request for Aurora, Mehrdad Nurolahzade and Zameer Manji.
Summary (updated)
-----------------
Fix performance regression in AttributeAggregate performance.
Bugs: AURORA-1802
https://issues.apache.org/jira/browse/AURORA-1802
Repository: aurora
Description
-------
This commit ensures AttributeAggregate will only be computed if needed by
limit constraints. This is the case in 0.16 but broken on master since the
introduction of scheduling attempts with multiple tasks.
In order to better model the latter this patch also updates the the
benchmarks to schedule multipe tasks per scheduleTask call.
Without the fix:
SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
thrpt 10 404.446 ± 31.252 ops/s
SchedulingBenchmarks.FillClusterBenchmark.runBenchmark thrpt 10 7.233 ±
3.058 ops/s
With the fix:
SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
thrpt 10 432.245 ± 16.963 ops/s
SchedulingBenchmarks.FillClusterBenchmark.runBenchmark thrpt 10 87.560 ±
14.600 ops/s
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java
631b2cfeec4f4ebd26d1d08fbd555f634ead3ac4
src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java
f04149e99ad9940e15ddabb6b98238495bb9d32a
src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml
91c76ca0f469c5b94b1ab290b40ddf43e44ee0c9
Diff: https://reviews.apache.org/r/53918/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Stephan Erb
