-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53928/#review156400
-----------------------------------------------------------


Ship it!




Nice!

- Bill Farner


On Nov. 19, 2016, 6:23 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53928/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2016, 6:23 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Before:
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>   1  thrpt   10  16.011 ± 0.323  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>  10  thrpt   10  15.141 ± 3.774  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
> 100  thrpt   10  16.178 ± 3.710  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark               
> 1000  thrpt   10  16.358 ± 0.540  ops/s
> 
> After:
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>   1  thrpt   10  41.832 ± 1.412  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>  10  thrpt   10  46.049 ± 3.435  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
> 100  thrpt   10  44.199 ± 1.272  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark               
> 1000  thrpt   10  38.722 ± 0.773  ops/s
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> d808c4cd2827f465cbd784a4d9d0fa496a7f8700 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorMetrics.java 
> 30bb814148b271cc9dfeebe016e8f8f92c2e3e41 
> 
> Diff: https://reviews.apache.org/r/53928/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> ./gradlew jmh -Pbenchmarks='SchedulingBenchmarks.PreemptorSlotSearchBenchmark'
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to