----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53965/ -----------------------------------------------------------
(Updated Nov. 21, 2016, 11:42 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, Mehrdad Nurolahzade, and Santhosh Kumar. Changes ------- fixed exported stats name and licensing checks. Repository: aurora Description ------- The timing of many methods are sampled with @Timed annotation. Currently SlidingSatas is being used to track total-msec-in-method-x and times-invoked-of-method-x and then compute the mean-msec-in-method-x-per-invocation. However mean values are known not to represent distrubtions with high skewness. This is request for review feedback for changes on computing stats, esp. timing stats by adding percentile. This patch introduces `SlidingTimedStats`, which uses `SlidingStats` to track the mean mean-msec-in-method-x-per-invocation for events in the last K sampling windows and `Percentiles` to track the p-values for msec-in-method-x for all invocations in the last K windows. __changes overview__: - Introduced `SlidingTimedStats` to measure percentiles on all @Timed method calls - Comments added for a better way to calculate ratio based on two rates (num and denom) in `SlidingStats`. - Tests added _sample new stat:_ attribute_store_fetch_one_10_0_percentile 0.0 attribute_store_fetch_one_50_0_percentile 0.0 attribute_store_fetch_one_90_0_percentile 0.0 attribute_store_fetch_one_99_0_percentile 0.0 attribute_store_fetch_one_99_9_percentile 0.0 attribute_store_fetch_one_99_99_percentile 0.0 Diffs (updated) ----- commons/src/main/java/org/apache/aurora/common/inject/TimedInterceptor.java a4c4240b67cafb108ca587ad86d9fb9d9bb1553d commons/src/main/java/org/apache/aurora/common/stats/SlidingStats.java f7a5ae41e307627fc55157758e9b7cdd861c3268 commons/src/main/java/org/apache/aurora/common/stats/SlidingTimedStats.java PRE-CREATION commons/src/test/java/org/apache/aurora/common/stats/SlidingTimedStatsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/53965/diff/ Testing ------- SlidingTimedStatsTest > passed Seems like gradle is not set to run tests on `common`. Tests passed in IDEA. Thanks, Reza Motamedi
