----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53923/#review156687 -----------------------------------------------------------
Master (320ee08) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 23, 2016, 1:25 a.m., Renan DelValle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53923/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 1:25 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Added filters whenever fromResource is called for a Protos.Resource in order > to avoid Aurora crashing. Previously only bagFromMesosResources was using the > SUPPORTED_RESOURCE filter. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java > 589288dc877d74eea1de65715fc498523be43d7f > > Diff: https://reviews.apache.org/r/53923/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > Tested by having a vagrant cluster run with an unsupported resource for an > hour this time in order to make sure it works. End to end testing has been > re-done. > > > Thanks, > > Renan DelValle > >
