-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54107/#review156977
-----------------------------------------------------------
Master (d56f8c6) is red with this patch.
./build-support/jenkins/build.sh
:distTar
:distZip
:assemble
:compileJmhJavaNote:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:1:
error: File contains a sequence of empty lines.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:1:
error: Line does not match expected header line of '^\/\*\*$'.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:4:8:
error: Unused import - java.util.Arrays.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:16:8:
error: Unused import - org.apache.aurora.common.stats.StatsProvider.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:35:13:
error: '(' is followed by whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:39:55:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:40:16:
error: '(' is followed by whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:43:45:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:44:16:
error: '(' is followed by whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:46:93:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:47:
error: '}' have incorrect indentation level 0, expected level should be 4.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:47:2:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:78:9:
error: '(' is followed by whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:88:50:
error: '(' is followed by whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:88:72:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java:92:
error: File contains a sequence of empty lines.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 12.947 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Nov. 27, 2016, 10:53 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54107/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2016, 10:53 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, Mehrdad
> Nurolahzade, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> MyBatis allows us to intercept calls within the execution of a mapped
> statement. This allows us to time various mapped statements and ultimately
> gain more insight on the performance of the database module.
>
> This patch introduces an interceptor on MyBatis on `updates` and `query`
> mapped statements. I used the following convention to create name for the
> newly collected stats:
> mybatis.<<the id of the mapped statement>>
>
> After interception the process is very similar to the one in
> @Timed-interceptor. SlidingStats can be used to export interval averages,
> total milliseconds and the event counts.
>
> __example stats (from ./vars.json)__
> mybatis.create_tables_events 1
> mybatis.create_tables_events_per_sec 0.0
> mybatis.create_tables_nanos_per_event 0.0
> mybatis.create_tables_nanos_total 592633784
> mybatis.create_tables_nanos_total_per_sec 0.0
> mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_events
> 3
> mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_events_per_sec
> 0.0
> mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_per_event
> 0.0
> mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_total
> 2858362
> mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_total_per_sec
> 0.0
> mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_events
> 333
> mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_events_per_sec
> 0.0
> mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_per_event
> 0.0
> mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_total
> 85745680
> mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_total_per_sec
> 0.0
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java
> e7287cec28e7b8ca978c506bfe821f261bc0ac26
>
> src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java
> PRE-CREATION
>
> src/test/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptorTest.java
> PRE-CREATION
>
> src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java
> 2e560c0d565689703b282391fe49dbf213ee25dc
>
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStoreTest.java
> 79999e19454568540c14f91808635bf8dff82bb3
>
> Diff: https://reviews.apache.org/r/54107/diff/
>
>
> Testing
> -------
>
> Tests are covered in InstrumentingInterceptorTest.
>
> - testStatIsCreatedOnce
> Tests that each stat is created one time only.
>
> - testInterceptMarksMetrics
> Tests that invocation is correctly intercepted and then proceeds.
>
>
> Thanks,
>
> Reza Motamedi
>
>
