----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54185/#review157344 -----------------------------------------------------------
Master (8e07b04) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 29, 2016, 10:47 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54185/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2016, 10:47 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > We can gain a little bit of performance if we only run the string formatting > when necessary. > > > Diffs > ----- > > src/main/java/org/apache/aurora/GuiceUtils.java > 879373b1c32373a1e52eb86261c7b92022463147 > src/main/java/org/apache/aurora/scheduler/base/Conversions.java > 66e69d444fdec1910ba2c557ad7f2ee248278030 > src/main/java/org/apache/aurora/scheduler/base/JobKeys.java > 7bbb1f73d2b61c26dc40f5a9c6e3602c1536400c > src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java > 9d981da2c765cbab58b906b34ab8b263633653a8 > > src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory.java > bb3bbbdfe810d40bfb163c84031cfd861e083586 > > src/main/java/org/apache/aurora/scheduler/http/api/security/ThriftFieldGetter.java > 2044b7985bd5f56c90c6e3140c2a505fea0cec19 > > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java > 343ffdbc3d720242a405e9743bda88b0edaab83d > > Diff: https://reviews.apache.org/r/54185/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
