Review Request 54250: Revert removal of twitter/commons/zk based leadership code

Thu, 01 Dec 2016 02:49:33 -0800 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54250/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen, John Sirois, Stephan Erb, and Zameer 
Manji.


Bugs: AURORA-1840
    https://issues.apache.org/jira/browse/AURORA-1840


Repository: aurora


Description
-------

Reverts the following two commits:
https://github.com/apache/aurora/commit/b417be38fe1fcae6b85f7e91cea961ab272adf3f
https://github.com/apache/aurora/commit/69cba786efc2628eab566201dfea46836a1d9af5


See discussion here: https://issues.apache.org/jira/browse/AURORA-1840


Diffs
-----

  RELEASE-NOTES.md 96926f4eb993578ea174d5a2f0ad75472803381d 
  build.gradle f257440e67384d9bd223b3c39785525bdb54dd9b 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 
PRE-CREATION 
  commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 
PRE-CREATION 
  commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 
PRE-CREATION 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java 
PRE-CREATION 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java 
PRE-CREATION 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 
PRE-CREATION 
  
commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java
 PRE-CREATION 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java 
PRE-CREATION 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 
PRE-CREATION 
  
commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java
 PRE-CREATION 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java 
PRE-CREATION 
  commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 
PRE-CREATION 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 
PRE-CREATION 
  commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 
PRE-CREATION 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java
 PRE-CREATION 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java
 PRE-CREATION 
  
commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java
 PRE-CREATION 
  config/findbugs/excludeFilter.xml 5eaa11afa0cbe9b6b078066266f36c8a86bc057f 
  docs/features/service-discovery.md 511c96d8bc65531f4fe637cf02d3ae9eb414964e 
  docs/reference/scheduler-configuration.md 
895565396a0c927e95bab774ec54c1b908350bc3 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
76209b12a80f24e410ed96fa8592021417354228 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
e0d32de4ebca05d2d6209ff373f8288e2e07b045 
  
src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule.java
 PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitor.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/discovery/Credentials.java 
75d58e7851ff2de986de533c35ccca2e4674f611 
  
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
 e690d1448a900484ee9723bb8cd47def1a6db31d 
  
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
 db886df60cddc490d1a45d31474547e351e81908 
  
src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
 321bbb3f6243547d31171692191acfebaf494c96 
  
src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java 
d5019bf6d94c82c1a6ab7265613822259eca5175 
  src/main/java/org/apache/aurora/scheduler/discovery/JsonCodec.java 
9d22b7683e37ed5cb5dbc0289c4f2aa58bc52347 
  
src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java 
b7ca62c11b6eebfa6b6ce00b2cebfdfea47214f3 
  src/main/java/org/apache/aurora/scheduler/discovery/ServiceGroupMonitor.java 
fea896c4efaf1252626fbe244f4e0aed6f17ef3a 
  src/main/java/org/apache/aurora/scheduler/discovery/SingletonService.java 
adbc31856a557530358b4f954c1c35a3318a6fb3 
  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
acb7905110563382ae878a0d928ee5496ac0fed7 
  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperUtils.java 
211aa50e6a31da28e17e9b2fe8515c0ea66c670c 
  
src/main/java/org/apache/aurora/scheduler/discovery/testing/BaseZooKeeperTest.java
 d84037e4349a20eb50ac76b49ba0e43a2ae3a707 
  
src/main/java/org/apache/aurora/scheduler/discovery/testing/ZooKeeperTestServer.java
 a7bb48b57890347cdd6f5c39f865e5fc44b4c1b3 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
af8567f5b65cf913f30fb64ced8f01564452bf83 
  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
662d6d55bf5e49afa4e2ef5b59e400f847bc4027 
  src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
c7c0387f2318021765ff27247677decabfaa3c4e 
  src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
4324ea9fc65ff273dbeb2ffa5af140fd2e1d344a 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
84d775394e7854a6fb9e6c335a2cb248d7cccb39 
  
src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java
 PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java
 9f86add9c2a3b797e36ad69e4006b7bed8994420 
  
src/test/java/org/apache/aurora/scheduler/discovery/CommonsDiscoveryModuleTest.java
 PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitorTest.java
 PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/discovery/CuratorDiscoveryModuleTest.java
 4ebda5eae6ad428fcccda49441bc97ca6e810e31 
  
src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java
 bb3d0807c533604f9e4216cb780bdfd22f50b9e9 
  src/test/java/org/apache/aurora/scheduler/discovery/JsonCodecTest.java 
b88ba37eec3c9dbe277441a99c9b9fd211896c6d 
  src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java 
4d833f2e4c0f70c21afdde108d1320f4146a0afb 
  src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
d9e73740786e771d0e781b5ed4e9211073704acd 
  src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
a308ba26cacfeaaed5b5e8fd6b664abad53bcf0d 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
0119ccb79c78db6a2a2508bbd48586c4bd2126a5 

Diff: https://reviews.apache.org/r/54250/diff/


Testing
-------

./src/test/sh/org/apache/aurora/e2e


Thanks,

David McLaughlin

Reply via email to