----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/#review158490 -----------------------------------------------------------
Ship it! Ship It! - Joshua Cohen On Dec. 8, 2016, 12:15 a.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54299/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 12:15 a.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Zameer Manji. > > > Bugs: AURORA-1841 > https://issues.apache.org/jira/browse/AURORA-1841 > > > Repository: aurora > > > Description > ------- > > It is possible to set the health checks such that a task can > continually fail health checks with intermittent successes and still > succeed an update. Essentially a task fails health checks during the > `initial_interval_secs` and an additional `max_consecutive_failures`, > and then perform a successful health check to become healthy. > > To be backward compatible to the above configuration, include the > `max_consecutive_failures` when computing `max_attempts_to_running`. > > > Diffs > ----- > > docs/features/services.md 50189eeff26ce9614d092f6abd9246788647fe2b > src/main/python/apache/aurora/executor/aurora_executor.py > d01fcb9594552eb6cdfbdbab2d03707738df3443 > src/main/python/apache/aurora/executor/common/health_checker.py > 12af9d8635a553eabe918a86508aa6ce2fd78a49 > src/test/python/apache/aurora/executor/common/test_health_checker.py > e2a7f164a24f49dd1f4cdba136e838b9d42d73a2 > > Diff: https://reviews.apache.org/r/54299/diff/ > > > Testing > ------- > > build-support/jenkins/build.sh > src/test/sh/org/apacher/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Santhosh Kumar Shanmugham > >
