----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54624/#review158871 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java (lines 66 - 75) <https://reviews.apache.org/r/54624/#comment229726> Nit: You could have used a constant String prefix (`zk_connection_state_`) + `state.name()` for naming stats here. src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java (line 67) <https://reviews.apache.org/r/54624/#comment229687> `zk_connection_state_connected`? src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java (lines 135 - 151) <https://reviews.apache.org/r/54624/#comment229728> I would rather prefer binary state (0/1 value) to counter-like stats here. See `org.apache.aurora.scheduler.SchedulerLifecycle` as an example. - Mehrdad Nurolahzade On Dec. 11, 2016, 5:32 p.m., Jing Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54624/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2016, 5:32 p.m.) > > > Review request for Aurora, Joshua Cohen, Mehrdad Nurolahzade, Stephan Erb, > and Zameer Manji. > > > Bugs: AURORA-1838 > https://issues.apache.org/jira/browse/AURORA-1838 > > > Repository: aurora > > > Description > ------- > > Expose stats on ZooKeeper connection state > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java > 999a542796858dcfe9e31601c47239189043fd52 > > Diff: https://reviews.apache.org/r/54624/diff/ > > > Testing > ------- > > http://192.168.33.7:8081/vars > ``` > zk_connection_state_connected 1 > zk_connection_state_lost 0 > zk_connection_state_readonly 0 > zk_connection_state_reconnected 0 > zk_connection_state_suspended 0 > zk_connection_state_unknown 0 > ``` > > > Thanks, > > Jing Chen > >
