----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54847/#review159585 -----------------------------------------------------------
Master (c42b1af) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 18, 2016, 11:51 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54847/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2016, 11:51 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > The stats I added around SnapshotFields are not applied because they are not > Guice-created instances. I've just removed them for now (adding timings > manually would be very repetitive here so there's probably a better > abstraction we can use). > > I added metrics to cover two pretty large parts of the Scheduler start-up > time: storage.prepare and storage.start. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > 9c9218ca6294eaddeb47b274393603bf47af61a8 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > 239f2eb475bec20acfcc2990d5d933f5bec83ed4 > > Diff: https://reviews.apache.org/r/54847/diff/ > > > Testing > ------- > > > Thanks, > > David McLaughlin > >
