----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54960/#review160112 -----------------------------------------------------------
LGTM, except for the following minor changes. src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java (lines 145 - 146) <https://reviews.apache.org/r/54960/#comment231116> `requireNonNull()` call here is not providing additional safety and should be removed. src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java (line 310) <https://reviews.apache.org/r/54960/#comment231117> Verify stat value. src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java (line 324) <https://reviews.apache.org/r/54960/#comment231118> Verify stat value. - Mehrdad Nurolahzade On Dec. 24, 2016, 8:01 a.m., Pradyumna Kaushik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54960/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2016, 8:01 a.m.) > > > Review request for Aurora and Mehrdad Nurolahzade. > > > Repository: aurora > > > Description > ------- > > Exposed stats on number of offers rescinded and number of slaves lost. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > d63bfc10442b791b423d0d8c83cc280610103299 > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java > 242530a8fdab8707e4ff79efae87da7bc840d247 > > Diff: https://reviews.apache.org/r/54960/diff/ > > > Testing > ------- > > curl -w '\n' 192.168.33.7:8081/vars | grep offers_rescinded > % Total % Received % Xferd Average Speed Time Time Time Current > Dload Upload Total Spent Left Speed > 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 > offers_rescinded 0 > > curl -w '\n' 192.168.33.7:8081/vars | grep slaves_lost > % Total % Received % Xferd Average Speed Time Time Time > Current > Dload Upload Total Spent Left Speed > 100 30970 0 30970 0 0 4323k 0 --:--:-- --:--:-- --:--:-- 5040k > slaves_lost 0 > > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Pradyumna Kaushik > >
