-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55027/
-----------------------------------------------------------

(Updated Dec. 27, 2016, 12:59 p.m.)


Review request for Aurora, David McLaughlin and Zameer Manji.


Changes
-------

I burned some time in `TaskSchedulerImplTest` trying to make 
`FakeStatsProvider` injection work and failed. For some reason 
`TaskSchedulerImplTest.statsProvider` is not picking up correct stat values.

Any idea?


Bugs: AURORA-1829
    https://issues.apache.org/jira/browse/AURORA-1829


Repository: aurora


Description (updated)
-------

AURORA-1829 (a) Preemption/Reservation BiCache expiration stats and (b) 
reservation cache removal stat


Diffs (updated)
-----

  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
fa37236e68657b539b182519b9d46d96d5b0953a 
  src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java 
70390f6b1ead322ebe3dd5d625dad44b70e2d185 
  src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
23d1c120657d5cb9d294a80c63e8a04512d361ca 
  src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
03a0e8485d1a392f107fda5b4af05b7f8f6067c6 
  src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 
203f62bacc47470545d095e4d25f7e0f25990ed9 
  src/test/java/org/apache/aurora/scheduler/preemptor/BiCacheTest.java 
bac8f3348fd7f369a60f6a492fa2d996e4c47b44 
  
src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
 d11ae5883f2a00dca4c4b36f0ab58ea95c7ecb2e 
  
src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java 
fa1a81785802b82542030e1aae786fe9570d9827 

Diff: https://reviews.apache.org/r/55027/diff/


Testing (updated)
-------

```
curl 192.168.33.7:8081/vars | grep _cache_expiration
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 43814    0 43814    0     0  7248k      0 --:--:-- --:--:-- --:--:-- 8557k
preemption_slot_cache_expiration 0
reservation_cache_expiration 0
```

```
curl 192.168.33.7:8081/vars | grep slave_reservation_removed
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 34420    0 34420    0     0  5548k      0 --:--:-- --:--:-- --:--:-- 6722k
slave_reservation_removed 0
```


Thanks,

Mehrdad Nurolahzade

Reply via email to