> On Dec. 27, 2016, 4:05 p.m., Stephan Erb wrote: > > I am really curious what this value will be in production :) The map could > > really end up being enourmous.
You are probably right, especially if scheduling constraints are used to pin jobs to hosts. > On Dec. 27, 2016, 4:05 p.m., Stephan Erb wrote: > > src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java, > > line 126 > > <https://reviews.apache.org/r/55058/diff/1/?file=1592748#file1592748line126> > > > > Is my understanding correct that we will now enforce that the methods > > are called exactly once and not more often? No, the `expectLastCall()` is redundant here and can be dropped (as it was). I prefer readable (verbose) to writable (implied) when it comes to testing logic. I can restore previous logic, if anyone feels strongly against the refactoring. > On Dec. 27, 2016, 4:05 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java, line 155 > > <https://reviews.apache.org/r/55058/diff/1/?file=1592747#file1592747line155> > > > > This sounds like it tracks the number of times an offer has received a > > static veto rather than data structure size. How about adding a `_size` to > > make this more clear? Will do. - Mehrdad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55058/#review160205 ----------------------------------------------------------- On Dec. 27, 2016, 2:53 p.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55058/ > ----------------------------------------------------------- > > (Updated Dec. 27, 2016, 2:53 p.m.) > > > Review request for Aurora, Stephan Erb and Zameer Manji. > > > Bugs: AURORA-1859 > https://issues.apache.org/jira/browse/AURORA-1859 > > > Repository: aurora > > > Description > ------- > > AURORA-1859 Expose stats on statically banned offers > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > 6c2b6d20658a7fe75725487c9a983e884d9ddfe5 > src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java > 5e570b6341c55be8ef27469077932d1ea8378b55 > > Diff: https://reviews.apache.org/r/55058/diff/ > > > Testing > ------- > > ``` > curl 192.168.33.7:8081/vars | grep statically_banned_offers > % Total % Received % Xferd Average Speed Time Time Time > Current > Dload Upload Total Spent Left Speed > 100 34379 0 34379 0 0 6747k 0 --:--:-- --:--:-- --:--:-- 8393k > statically_banned_offers 1 > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
