> On Dec. 29, 2016, 1:07 p.m., Stephan Erb wrote: > > Have you considered extending `ThriftStatsExporterInterceptor` > > (https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor.java)? > > > > At least all the read only getters could be implemented in a generic > > fashion by always aggregating the size of of the various fields in the > > thrift Result union.
I actually did but then gave up after seeing that the non-readonly path does not conform to the pattern on the readonly side. However, thinking about it again maybe it makes sense to automate it for the readonly execution path. Let me try that and see what it's going to be like. - Mehrdad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55089/#review160283 ----------------------------------------------------------- On Dec. 29, 2016, 10:45 a.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55089/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2016, 10:45 a.m.) > > > Review request for Aurora, David McLaughlin and Stephan Erb. > > > Bugs: AURORA-1826 > https://issues.apache.org/jira/browse/AURORA-1826 > > > Repository: aurora > > > Description > ------- > > AURORA-1826 Expose Thrift server request workload stats > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java > bba1161a48738e19f10fcf72395f8d70b481ed13 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 > > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java > 6d0e9bc6a8040393875d4f0a88e8db9d6926a88b > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > b28cd2489a52041a8e7e53f298fad8d8cd29406f > > Diff: https://reviews.apache.org/r/55089/diff/ > > > Testing > ------- > > ``` > curl 192.168.33.7:8081/vars | grep thrift_workload > % Total % Received % Xferd Average Speed Time Time Time > Current > Dload Upload Total Spent Left Speed > 100 41334 0 41334 0 0 3695k 0 --:--:-- --:--:-- --:--:-- 4036k > thrift_workload_addInstances 0 > thrift_workload_createJob 0 > thrift_workload_createOrUpdateCronTemplate 0 > thrift_workload_drainHosts 0 > thrift_workload_endMaintenance 0 > thrift_workload_getConfigSummary 0 > thrift_workload_getJobSummary 0 > thrift_workload_getJobUpdateDetails 0 > thrift_workload_getJobUpdateSummaries 0 > thrift_workload_getJobs 0 > thrift_workload_getPendingReason 0 > thrift_workload_getRoleSummary 0 > thrift_workload_getTaskStatus 0 > thrift_workload_getTasksWithoutConfigs 0 > thrift_workload_killTasks 0 > thrift_workload_maintenanceStatus 0 > thrift_workload_restartShards 0 > thrift_workload_rewriteConfigs 0 > thrift_workload_startJobUpdate 0 > thrift_workload_startMaintenance 0 > ``` > > ``` > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > ... > > *** OK (All tests passed) *** > > mesos-master start/running, process 2359 > + RETCODE=0 > + restore_netrc > + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc > + true > Connection to 127.0.0.1 closed. > > real 28m58.389s > user 0m1.508s > sys 0m0.820s > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
