----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55578/#review161739 -----------------------------------------------------------
Master (b75dfb8) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 16, 2017, 2:44 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55578/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 2:44 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Bugs: AURORA-1541 > https://issues.apache.org/jira/browse/AURORA-1541 > > > Repository: aurora > > > Description > ------- > > The observer's logs consist of lots of warnings about being unable to find > PIDs. This is expected when running with the PID isolator, or when tasks when > the checkpoint is out of date (e.g. if processes were killed by the OOM). > > W0116 14:42:54.694221 3253 process_collector_psutil.py:75] Error during > process sampling: psutil.NoSuchProcess process no longer exists (pid=27727) > W0116 14:42:54.717905 3253 process_collector_psutil.py:42] Error during > process sampling [pid=10960]: psutil.NoSuchProcess process no longer exists > (pid=10960) > W0116 14:42:54.718089 3253 process_collector_psutil.py:75] Error during > process sampling: psutil.NoSuchProcess process no longer exists (pid=10960) > W0116 14:42:54.718245 3253 process_collector_psutil.py:42] Error during > process sampling [pid=10026]: psutil.NoSuchProcess process no longer exists > (pid=10026) > W0116 14:42:54.718334 3253 process_collector_psutil.py:75] Error during > process sampling: psutil.NoSuchProcess process no longer exists (pid=10026) > > This change adopts the proposal of David Robinson to decrease the severity > level to debug. > > > Diffs > ----- > > src/main/python/apache/thermos/monitoring/process_collector_psutil.py > 4a1b159637ae18113aa7f4d10a0864be0fd1e920 > > Diff: https://reviews.apache.org/r/55578/diff/ > > > Testing > ------- > > ./pants test.pytest src/{main,test}/python:: -- -v > > > Thanks, > > Stephan Erb > >
