> On Jan. 17, 2017, 3:28 p.m., Aurora ReviewBot wrote:
> > Master (4e92be4) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > -----------
> > * What went wrong:
> > Execution failed for task ':analyzeReport'.
> > > Test coverage missing for
> > > org/apache/aurora/scheduler/storage/db/views/DbImage
> > Test coverage missing for org/apache/aurora/scheduler/http/Mname
> > Test coverage missing for org/apache/aurora/scheduler/http/Services
> > Test coverage missing for org/apache/aurora/scheduler/http/QuitCallback
> > Test coverage missing for org/apache/aurora/scheduler/http/Cron
> > Test coverage missing for org/apache/aurora/scheduler/app/VolumeParser
> > Test coverage missing for
> > org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader$Schema
> > Test coverage missing for
> > org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader
> > Test coverage missing for
> > org/apache/aurora/scheduler/pruning/TaskHistoryPruner$1
> > Test coverage missing for
> > org/apache/aurora/scheduler/stats/AsyncStatsModule$OfferAdapter
> > Test coverage missing for
> > org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule
> > Test coverage missing for
> > org/apache/aurora/scheduler/http/api/security/ShiroUtils
> > Test coverage missing for
> > org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$3
> > Test coverage missing for
> > org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$2
> > Test coverage missing for
> > org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser
> > Test coverage missing for
> > org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule
> > Test coverage missing for
> > org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule$1
> > Test coverage missing for
> > org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream
> > Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog
> > Test coverage missing for
> > org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$OpStats
> > Test coverage missing for
> > org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$1
> > Test coverage missing for
> > org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogEntry
> > Test coverage missing for
> > org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogPosition
> > Test coverage missing for
> > org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule
> > Test coverage missing for
> > org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt
> > Test coverage missing for
> > org/apache/aurora/scheduler/preemptor/Preemptor$PreemptorImpl
> > Test coverage missing for
> > org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected
> > Test coverage missing for
> > org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered
> > Test coverage missing for
> > org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or
> > --debug option to get more log output.
> > ==============================================================================
> >
> > BUILD FAILED
> >
> > Total time: 52 mins 15.294 secs
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
This appears to have been:
```
...
Exception applying rule InvalidSlf4jMessageFormat on file
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java,
continuing with next rule
java.lang.NullPointerException
at
net.sourceforge.pmd.lang.java.rule.logging.InvalidSlf4jMessageFormatRule.countPlaceholders(InvalidSlf4jMessageFormatRule.java:199)
at
net.sourceforge.pmd.lang.java.rule.logging.InvalidSlf4jMessageFormatRule.getAmountOfExpectedArguments(InvalidSlf4jMessageFormatRule.java:192)
at
net.sourceforge.pmd.lang.java.rule.logging.InvalidSlf4jMessageFormatRule.expectedArguments(InvalidSlf4jMessageFormatRule.java:171)
at
net.sourceforge.pmd.lang.java.rule.logging.InvalidSlf4jMessageFormatRule.visit(InvalidSlf4jMessageFormatRule.java:88)
...
```
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55646/#review161973
-----------------------------------------------------------
On Jan. 17, 2017, 2:30 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55646/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 2:30 p.m.)
>
>
> Review request for Aurora and Joshua Cohen.
>
>
> Bugs: AURORA-1875
> https://issues.apache.org/jira/browse/AURORA-1875
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We use these for the Aurora UI and the API docs.
>
> build-support/thrift/thriftw | 2 ++
> 1 file changed, 2 insertions(+)
>
>
> Diffs
> -----
>
> build-support/thrift/thriftw 278576f22b6127da306e2b12ece3686981a317d3
>
> Diff: https://reviews.apache.org/r/55646/diff/
>
>
> Testing
> -------
>
> Missed these 2 in https://reviews.apache.org/r/55536/
>
> Our custom thrift build does not rebuild since it passes the new checks:
> ```
> $ ./build-support/thrift/thriftw 0.9.1 --which
> /home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/compiler/cpp/thrift
> $ ./build-support/thrift/thriftw 0.9.1 -help 2>&1 | grep -iE "javascript|html"
> html (HTML):
> standalone: Self-contained mode, includes all CSS in the HTML files.
> Generates no style.css file, but HTML files will be
> larger.
> js (Javascript):
> ```
>
>
> Thanks,
>
> John Sirois
>
>
