> On Jan. 23, 2017, 2:16 p.m., Aurora ReviewBot wrote: > > Master (75129b6) is red with this patch. > > ./build-support/jenkins/build.sh > > > > Test coverage missing for org/apache/aurora/scheduler/events/Webhook > > Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$8 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$7 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$4 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$3 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$6 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$5 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$2 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$1 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/LogStorage$Settings > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService > > Test coverage missing for > > org/apache/aurora/scheduler/storage/log/LogStorageModule > > Test coverage missing for > > org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1 > > Test coverage missing for > > org/apache/aurora/scheduler/storage/backup/BackupModule > > Test coverage missing for > > org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl > > Test coverage missing for > > org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory > > Test coverage missing for > > org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery > > Test coverage missing for org/apache/aurora/scheduler/TaskVars > > Test coverage missing for > > org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions > > Test coverage missing for > > org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig > > Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter > > Test coverage missing for org/apache/aurora/scheduler/TaskVars$1 > > Test coverage missing for > > org/apache/aurora/scheduler/SchedulerModule$TaskEventBatchWorker > > Test coverage missing for org/apache/aurora/scheduler/HostOffer$1 > > Test coverage missing for org/apache/aurora/scheduler/SchedulerModule > > Test coverage missing for > > org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl > > Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$1 > > Test coverage missing for > > org/apache/aurora/scheduler/TaskStatusHandlerImpl > > Test coverage missing for > > org/apache/aurora/scheduler/TaskStatusHandlerImpl$1 > > > > * Try: > > Run with --stacktrace option to get the stack trace. Run with --info or > > --debug option to get more log output. > > ============================================================================== > > > > BUILD FAILED > > > > Total time: 4 mins 50.396 secs > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry"
This was an incidence of the now well-known: ``` :testJava HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x00000007a8e80000, 298319872, 0) failed; error='Cannot allocate memory' (errno=12) ``` I'll spin one more retry and then submit this if green. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162700 ----------------------------------------------------------- On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54288/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2017, 1:21 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and > Stephan Erb. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > ------- > > As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates > leadership if the ZK connection is lost or if there is a timeout. This is not > compatible with the commons based implementation which would only abdicate > leadership if the ZK session timeout occurred. > > This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a > custom listener that only loses leadership if a connection loss occurs. > > > Diffs > ----- > > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 50acaeba82e163f8f2970a264cbd889c9eb3b5ed > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java > c378172c850aafe0a9381552b5067277b40dbfab > > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java > a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583 > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java > 6ea49b0c690d288ff59d1d4798144bfa2d153d3a > > Diff: https://reviews.apache.org/r/54288/diff/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > >
